This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
Fixes problem with automatic merges #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeee
changed the title
|
I just merged mockito/shipkit-example#170 using the rest api also used in this pr and it did work 😄 |
mockitoguy
approved these changes
Feb 28, 2018
| @@ -50,7 +50,7 @@ public void mergePullRequest(MergePullRequestTask task, GitHubApi gitHubApi, Git | |||
| } | |||
|
|
|||
| LOG.lifecycle("All checks passed! Merging pull request in repository '{}' between base = '{}' and head = '{}'.", task.getUpstreamRepositoryName(), task.getBaseBranch(), headBranch); | |||
| gitHubApi.post("/repos/" + task.getUpstreamRepositoryName() + "/merges", body); | |||
| gitHubApi.post("/repos/" + task.getUpstreamRepositoryName() + "/pulls/" + task.getPullRequestNumber() + "/merge", body); | |||
There was a problem hiding this comment.
This is a nice change. Thank you!
|
|
||
| import spock.lang.Specification | ||
|
|
||
| class BranchUtilsTest extends Specification { |
There was a problem hiding this comment.
Cool! Thank you for adding missing test.
|
Merging. Nice change! |
mockitoguy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #646