Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

#362 Improving Shipkit documentation #752

Merged
merged 2 commits into from Jan 3, 2019
Merged

#362 Improving Shipkit documentation #752

merged 2 commits into from Jan 3, 2019

Conversation

mstachniuk
Copy link
Contributor

Add detailed sequence diagram

Code used for generating Sequence diagram:
https://gist.github.com/mstachniuk/3cccbb2a501bab0d89f8db6af544a51d

@mstachniuk
#362 Improving Shipkit documentation
0c3d603 
Add detailed sequence diagram
epeee
epeee reviewed Sep 16, 2018
View reviewed changes
Copy link
Contributor

@epeee epeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the additional doc.
We have to consider to keep it up to date.
Other than that I only see one downside: due to the layout you only see a small part of the diagram and one have to scroll a lot.

@mstachniuk
#362 Improving Shipkit documentation
c08dc75 
Split diagram to 3 diagrams
@mstachniuk
Copy link
Contributor Author

I split diagram to 3 smaller diagrams and now it should be less to scroll

@epeee
Copy link
Contributor

epeee commented Jan 3, 2019

Thank you!
In fact the layout looks better now.

@mstachniuk mstachniuk merged commit 2f911b3 into master Jan 3, 2019
@mstachniuk mstachniuk deleted the ms branch January 3, 2019 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epeee epeee epeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstachniuk @epeee