Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1031 status code logging list #1048

Merged

Conversation

vishwasganatra
Copy link
Contributor

Closes #1031

Technical implementation details

Checklist

  • data migration added (@mockoon/commons)
  • data migration automated tests added (@mockoon/commons)
  • CLI automated tests added (@mockoon/cli)
  • desktop automated tests added (@mockoon/desktop)

Copy link
Member

@255kb 255kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks really nice!
I suggested 3 small changes that mainly avoid overflow and layout breaking when the date is longer or column smaller (it would be ok as-is, but like that it's future proof :) )

@vishwasganatra vishwasganatra requested a review from 255kb May 24, 2023 03:08
@255kb 255kb merged commit bc258b0 into mockoon:main May 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Response Status Code in logging list.
2 participants