Added crudkey property, updated environment and databucket actions #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ce1041
force-pushed
the
feature/1041-implement-crudkey-index
branch
4 times, most recently
from
5e90da7
to
d3d8cc2
Compare
255kb
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Thank you for the PR.
Most of the requested changes are to avoid a serve restart, + some minor UI changes.
Let me know if you have questions.
PS: desktop tests are not passing. You have to migrate the test environments by running node .//scripts/migrate-tests.js inside the ./packages/desktop folder.
...ges/desktop/src/renderer/app/components/environment-routes/environment-routes.component.html
Outdated
Show resolved
Hide resolved
...ges/desktop/src/renderer/app/components/environment-routes/environment-routes.component.html
Outdated
Show resolved
Hide resolved
...ges/desktop/src/renderer/app/components/environment-routes/environment-routes.component.html
Outdated
Show resolved
Hide resolved
...ges/desktop/src/renderer/app/components/environment-routes/environment-routes.component.html
Outdated
Show resolved
Hide resolved
n1ce1041
force-pushed
the
feature/1041-implement-crudkey-index
branch
from
d3d8cc2
to
346ef2c
Compare
255kb
requested changes
Jul 18, 2023
n1ce1041
force-pushed
the
feature/1041-implement-crudkey-index
branch
3 times, most recently
from
935caa1
to
5693f36
Compare
n1ce1041
force-pushed
the
feature/1041-implement-crudkey-index
branch
from
5693f36
to
3a8abeb
Compare
255kb
approved these changes
Jul 20, 2023
255kb
added a commit
that referenced
this pull request
Jul 24, 2023
* Logs standardization (#1064) - add log transaction option to serverless and desktop - extract server logging to commons-server - standardize how server is logging its events - use same logger (winston) for all the applications - redact authorization headers when logging to file Closes #978 Closes #688 Closes #1063 * Add context menu entry to move an environment file (#1065) Closes #1062 * Review desktop messages and logging after #1063 * Fix documentation generator * Enable OpenAPI `example` export (#1067) fixes OpenAPI export crashing with CRUD routes Closes #352 Closes #1066 * Make `data` helpers compatible with safestring (#1071) Closes #1069 * Remove reload view and rewrite change detection use custom rxjs operator that listen to the object changed and some reducer actions that always force the refresh Also disable template generation on pressing enter if quota reached * Switch lerna version to fixed * Add stringify option to oneof helper * Allow search of hidden routes in the desktop app (#1083) Automatically uncollapse parent folders of selected route after a search Closes #960 * Fix for faker methods with numbers in their names (#1084) * Enable watch mode for libraries Closes #1076 * Added crudkey property, updated environment and databucket actions (#1082) * Added crudkey property, updated environment and databucket actions * Updated crudKey to be a property of RouteResponse Closes #1041 * Fix package lock and crudKey tooltip wording * Move crudKey field next to CRUD data bucket selector in desktop app * CLI refactoring (#1090) - remove PM2 dependency - remove list and stop commands, remove `--pname` flag - make foreground the default and remove the `--daemon-flag` - simplify the dockerize command to only generates a Dockerfile, and enable file downloading - remove some dependencies to simplify maintenance (inquirer, etc.) Closes #1081 * Update repository images * Update CLI documentation headers and links * Enable truncation for log menu entries in desktop app Closes #1085 * Update dependencies * New prettier format --------- Co-authored-by: ajatkj <ajatkj@yahoo.co.in> Co-authored-by: n1ce1041 <70496526+n1ce1041@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical implementation details
Don't think I need CLI tests, but will add in if required.
Closes #1041