-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import and export using CLI #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the change requests on the code, here are some general remarks:
- Should we also have a
--prettify
option in th export like you did for the import? - don't forget to update the documentation in the readme for both commands (you can follow the format of the other commands)
Thank you!
Hello, @255kb! Sorry about the delay. |
Thanks @Mavbraz , let me know if you need anything. |
I think it's more important having this prettify in the export command. FYI: I also updated the commons-server to be able to prettify in other parts of Mockoon if necessary in the future. |
8325328
to
d300a2f
Compare
It's still missing to update the README and add few tests to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I requested some changes as in the meantime I removed support for the legacy file format. You can remove these test cases, it should make the CI pass too.
Only the readme doc is remaining, and after that we are good to go!
09605e0
to
3fa184b
Compare
e6a57ed
to
c8a1c15
Compare
Thanks for the changes! |
Closes #678
Technical implementation details
Checklist
data
andoutput
port
andprettify
parseDataFiles
method then a error message will be returned.data
andoutput
type
('open-api-v3'
is default)