Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/962 Use OpenAPI examples #967

Merged
merged 4 commits into from Feb 28, 2023
Merged

Feature/962 Use OpenAPI examples #967

merged 4 commits into from Feb 28, 2023

Conversation

mathilde-lannes
Copy link
Contributor

@mathilde-lannes mathilde-lannes commented Feb 27, 2023 •
edited by 255kb

Closes #962

Technical implementation details

When importing an OpenAPI specification file, the examples property of the specification is used to generate new route responses. Each example is transformed in a new route response and the default route response is the one generated from the schema property.

Checklist

  • data migration added (@mockoon/commons)
  • data migration automated tests added (@mockoon/commons)
  • CLI automated tests added (@mockoon/cli)
  • desktop automated tests added (@mockoon/desktop)

@mathilde-lannes mathilde-lannes changed the title Closes #962 Feature/962 Use OpenAPI examples Feb 27, 2023
255kb
255kb requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@255kb 255kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and for adding tests in the commons-server package.
There is a small issue that is breaking the desktop tests.

packages/commons-server/src/libs/openapi-converter.ts Outdated Show resolved Hide resolved
@255kb 255kb merged commit 946c5c4 into mockoon:main Feb 28, 2023
@bodrick bodrick mentioned this pull request Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@255kb 255kb 255kb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use OpenAPI examples
2 participants
@mathilde-lannes @255kb