add typing support to make and prepare #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper typing for enabling at least PyCharm to support proper code completion and silence type warnings in
baker.make
andbaker.prepare
calls.baker.make
not being ofType[ModelBase]
, which is correct, as we're passing derived models, not theModelBase
._quantity
parameter, it now correctly lists fields and methods for the passed model class besides thelist
interface. I.e., we do not need to writemocked_model: SomeModel = baker.make(SomeModel)
every time, and instead can rely on automatic type deduction now without explicitly specifying the model type of the variable.