Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix {,e}println!() #3209

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix {,e}println!() #3209

merged 2 commits into from
May 29, 2024

Conversation

GrigorenkoPV
Copy link
Contributor

GitHub closed the previous PR (#3205) after I renamed a branch, hooray.

Change the implementation of println! & eprintln! with no arguments to call print!("\n")
& eprint!("\n") respectively instead of producing no tokens. This is what std does. 12

Resolves #3204.

A test included, as per #3205 (comment)

Footnotes

  1. https://github.com/rust-lang/rust/blob/8c127df75fde3d5ad8ef9af664962a7676288b52/library/std/src/macros.rs#L140 ↩

  2. https://github.com/rust-lang/rust/blob/8c127df75fde3d5ad8ef9af664962a7676288b52/library/std/src/macros.rs#L218 ↩

@GrigorenkoPV GrigorenkoPV requested a review from a team as a code owner May 29, 2024 11:10
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label May 29, 2024
zhassan-aws
zhassan-aws approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhassan-aws zhassan-aws enabled auto-merge (squash) May 29, 2024 15:55
@zhassan-aws zhassan-aws merged commit 7eb6ce7 into model-checking:main May 29, 2024
23 checks passed
@GrigorenkoPV GrigorenkoPV deleted the println branch May 29, 2024 20:09
tautschnig added a commit to tautschnig/kani that referenced this pull request Jun 4, 2024
@tautschnig
Bump Kani version to 0.52.0
fb87e39 
Updated version in all `Cargo.toml` files (via `find . -name Cargo.toml -exec
sed -i 's/version = "0.51.0"/version = "0.52.0"/' {} \;`) and ran `cargo
build-dev` to have `Cargo.lock` files updated.

GitHub generated release notes:

 ## What's Changed
* Bump tests/perf/s2n-quic from `6dd41e0` to `bd37960` by @dependabot in model-checking#3178
* Automatic cargo update to 2024-05-13 by @github-actions in model-checking#3177
* Upgrade toolchain to 2024-04-22 by @zhassan-aws in model-checking#3171
* Upgrade toolchain to 2024-05-14 by @zhassan-aws in model-checking#3183
* Automatic toolchain upgrade to nightly-2024-05-15 by @github-actions in model-checking#3185
* Include `--check-cfg=cfg(kani)` in the rust flags to avoid a warning about an unknown `cfg`. by @zhassan-aws in model-checking#3187
* Automatic toolchain upgrade to nightly-2024-05-16 by @github-actions in model-checking#3189
* Perform cargo update because of yanked libc version by @zhassan-aws in model-checking#3192
* Automatic toolchain upgrade to nightly-2024-05-17 by @github-actions in model-checking#3191
* Automatic cargo update to 2024-05-20 by @github-actions in model-checking#3195
* Bump tests/perf/s2n-quic from `bd37960` to `f5d9d74` by @dependabot in model-checking#3196
* New section about linter configuraton checking in the doc. by @remi-delmas-3000 in model-checking#3198
* Automatic cargo update to 2024-05-27 by @github-actions in model-checking#3201
* Bump tests/perf/s2n-quic from `f5d9d74` to `d03cc47` by @dependabot in model-checking#3202
* Update Rust toolchain from nightly-2024-05-17 to nightly-2024-05-23 by @remi-delmas-3000 in model-checking#3199
* Fix `{,e}println!()` by @GrigorenkoPV in model-checking#3209
* Contracts for a few core functions by @celinval in model-checking#3107
* Don't crash benchcomp when rounding non-numeric values by @karkhaz in model-checking#3211
* Update Rust toolchain nightly-2024-05-24 by @qinheping in model-checking#3212
* Upgrade Rust toolchain nightly-2024-05-27  by @qinheping in model-checking#3215
* Automatic toolchain upgrade to nightly-2024-05-28 by @github-actions in model-checking#3217
* Automatic cargo update to 2024-06-03 by @github-actions in model-checking#3220
* Bump tests/perf/s2n-quic from `d03cc47` to `d90729d` by @dependabot in model-checking#3222
* Add simple API for shadow memory by @zhassan-aws in model-checking#3200

 ## New Contributors
* @GrigorenkoPV made their first contribution in model-checking#3209

**Full Changelog**: model-checking/kani@kani-0.51.0...kani-0.52.0
@tautschnig tautschnig mentioned this pull request Jun 4, 2024
Merged
tautschnig added a commit that referenced this pull request Jun 4, 2024
@tautschnig
Bump Kani version to 0.52.0 (#3224)
358ade9 
Updated version in all `Cargo.toml` files (via `find . -name Cargo.toml
-exec sed -i 's/version = "0.51.0"/version = "0.52.0"/' {} \;`) and ran
`cargo build-dev` to have `Cargo.lock` files updated.

GitHub generated release notes:

 ## What's Changed
* Bump tests/perf/s2n-quic from `6dd41e0` to `bd37960` by @dependabot in
#3178
* Automatic cargo update to 2024-05-13 by @github-actions in
#3177
* Upgrade toolchain to 2024-04-22 by @zhassan-aws in
#3171
* Upgrade toolchain to 2024-05-14 by @zhassan-aws in
#3183
* Automatic toolchain upgrade to nightly-2024-05-15 by @github-actions
in #3185
* Include `--check-cfg=cfg(kani)` in the rust flags to avoid a warning
about an unknown `cfg`. by @zhassan-aws in
#3187
* Automatic toolchain upgrade to nightly-2024-05-16 by @github-actions
in #3189
* Perform cargo update because of yanked libc version by @zhassan-aws in
#3192
* Automatic toolchain upgrade to nightly-2024-05-17 by @github-actions
in #3191
* Automatic cargo update to 2024-05-20 by @github-actions in
#3195
* Bump tests/perf/s2n-quic from `bd37960` to `f5d9d74` by @dependabot in
#3196
* New section about linter configuraton checking in the doc. by
@remi-delmas-3000 in #3198
* Automatic cargo update to 2024-05-27 by @github-actions in
#3201
* Bump tests/perf/s2n-quic from `f5d9d74` to `d03cc47` by @dependabot in
#3202
* Update Rust toolchain from nightly-2024-05-17 to nightly-2024-05-23 by
@remi-delmas-3000 in #3199
* Fix `{,e}println!()` by @GrigorenkoPV in
#3209
* Contracts for a few core functions by @celinval in
#3107
* Don't crash benchcomp when rounding non-numeric values by @karkhaz in
#3211
* Update Rust toolchain nightly-2024-05-24 by @qinheping in
#3212
* Upgrade Rust toolchain nightly-2024-05-27 by @qinheping in
#3215
* Automatic toolchain upgrade to nightly-2024-05-28 by @github-actions
in #3217
* Automatic cargo update to 2024-06-03 by @github-actions in
#3220
* Bump tests/perf/s2n-quic from `d03cc47` to `d90729d` by @dependabot in
#3222
* Add simple API for shadow memory by @zhassan-aws in
#3200

 ## New Contributors
* @GrigorenkoPV made their first contribution in
#3209

**Full Changelog**:
kani-0.51.0...kani-0.52.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feliperodri feliperodri feliperodri approved these changes

@zhassan-aws zhassan-aws zhassan-aws approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

println!() with no trailing semicolon causes an error
3 participants
@GrigorenkoPV @feliperodri @zhassan-aws