Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out function-partial-application #2490

Merged
merged 3 commits into from Mar 19, 2020
Merged

Factor out function-partial-application #2490

merged 3 commits into from Mar 19, 2020

Conversation

HansOlsson
Copy link
Collaborator

Closes #2250

@HansOlsson HansOlsson added this to the Phone2020-1 milestone Mar 13, 2020
svorkoetter
svorkoetter approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@svorkoetter svorkoetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

sjoelund
sjoelund approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but I would prefer if we had the formal grammar ready to make sure we don't break anything

@HansOlsson HansOlsson merged commit 2f0c7ee into modelica:master Mar 19, 2020
@HansOlsson HansOlsson deleted the FactorOutFunctionPartial branch March 19, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoelund sjoelund sjoelund approved these changes

@svorkoetter svorkoetter svorkoetter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Phone2020-1
Development

Successfully merging this pull request may close these issues.

Grammar for function partial application.
3 participants
@HansOlsson @sjoelund @svorkoetter