Clarify the uniqueness of Figure and Plot identifiers #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
approved these changes
Apr 9, 2020
| \lstinline!identifier! must be unique among the \lstinline!plots! in the | ||
| \lstinline!Figure! annotation. | ||
| The \lstinline!identifier! in \lstinline!Figure! and \lstinline!Plot! is an | ||
| optional \lstinline!String! identifier, and is intended to identify the |
There was a problem hiding this comment.
Is it necessary to say it's a String here, given the pseudo-code record definitions?
There was a problem hiding this comment.
Part of the confusion was about the identifiers living in the same namespace as everything else, spelling out String here should make that more clear.
There was a problem hiding this comment.
OK, let's see if it the kind of clarification @gkurzbach was looking for, and perhaps see if @HansOlsson wants to have a say on the general style.
There was a problem hiding this comment.
Ok, I think it is fine now.
HansOlsson
reviewed
Apr 15, 2020
HansOlsson
approved these changes
Apr 15, 2020
|
Shall we merge it to MCP/0033? |
|
Yes, it seems like @gkurzbach has nothing more to add. |
|
@henrikt-ma you are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.