Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latexml 0.8.4 #2546

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Update to latexml 0.8.4 #2546

merged 1 commit into from
Apr 16, 2020

Conversation

sjoelund
Copy link
Member

No description provided.

@sjoelund sjoelund mentioned this pull request Apr 15, 2020
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except I don't know if the redundant "-path" setting for images is needed here as well;
and then this and the other PR needs to be coordinated I guess.
Have you checked if -path is needed here?

@HansOlsson HansOlsson added the CI Issue that addresses continuous integration label Apr 15, 2020
@sjoelund
Copy link
Member Author

Where do you see -path? Or was that in the other PR?

Fatal:perl:die Perl died

	bad ns attribute! at /usr/local/lib/x86_64-linux-gnu/perl/5.26.1/XML/LibXML.pm line 1687.

	In Post::Document[A4.html] ->addNodes

	 <= Post::CrossRef[@0x55af5e25d998]

1 warning; 1 fatal error

@sjoelund
Copy link
Member Author

Maybe cherry-pick these commits into #2545? Note that the Jenkinsfile runs its own latexml commands and not the ones in the makefile.

@HansOlsson
Copy link
Collaborator

Where do you see -path? Or was that in the other PR?

In Makefile of other PR, --path=media; so I guess it is necessary to repeat that in the CI-command as well.

@sjoelund
Copy link
Member Author

That didn't seem to do it either :(

@sjoelund
Copy link
Member Author

If I make derivationofstream.tex empty, it works...

@sjoelund
Copy link
Member Author

It seems math context in subsection is no longer working in 0.8.4:

-\subsection{Connection of 3 stream connectors where one mass flow rate is identical to zero (N=3 and $\dot{m}_3=0$):}\doublelabel{connection-of-3-stream-connectors-where-one-mass-flow-rate-is-identical-to-zero-n-3-and}
+\subsection{Connection of 3 stream connectors where one mass flow rate is identical to zero}\doublelabel{connection-of-3-stream-connectors-where-one-mass-flow-rate-is-identical-to-zero-n-3-and}

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HansOlsson HansOlsson merged commit cbe1bc1 into modelica:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue that addresses continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants