Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New latex ml #2545

Merged
merged 5 commits into from
Apr 21, 2020
Merged

New latex ml #2545

merged 5 commits into from
Apr 21, 2020

Conversation

HansOlsson
Copy link
Collaborator

Including 0.8.4 changes for the splitting of files.
It took a bit longer than planned because I had to track down the issue with images (and I should likely file a bug-report for it.)

@sjoelund sjoelund self-requested a review April 15, 2020 06:33
Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is still running 0.8.3 latexml. But it seems to have worked anyway; is it OK with this docker image or do I need to update it as well?

@dietmarw
Copy link
Member

@sjoelund You should update the docker image aswell since that would also allow the usage of subfiles then.

@HansOlsson HansOlsson added the LaTeX Issue with the LaTeX code label Apr 15, 2020
@HansOlsson
Copy link
Collaborator Author

I have now investigated further.

We can now use standard LaTeXML 0.8.4 (so no need for a special hack) and still get nice anchors, and also chapter names:

  • Just use --splitnaming=labelrelative; and it works now!
  • The downside is that all old references for specification.modelica.org would cease to work. That can be handled by adding file-links (soft or hard). Only about 30 links so should be straightforward, but I don't know how to do it as part of process.

@HansOlsson
Copy link
Collaborator Author

To clarify: I haven't committed that change of Makefile yet; but can do that - together with the links.
It requires that all chapters have a label - explaining the last commit.

@sjoelund
Copy link
Member

#2546 has latexml 0.8.4 instead of Hans patched version.

@HansOlsson
Copy link
Collaborator Author

I have now added the soft links for previous version as part of Jenkins (hoping that suffices), and changed to use the new labelrelative.

@HansOlsson
Copy link
Collaborator Author

I could even see that the generated symlinks seem to work, even when downloaded to Windows.
(After realizing I had to unzip as Admin! 🤦‍♂️ )

@HansOlsson
Copy link
Collaborator Author

Can this be approved?

@dietmarw
Copy link
Member

I did not have time to run this on my machine but if you are fine I can silently approve it.

@HansOlsson
Copy link
Collaborator Author

I did not have time to run this on my machine but if you are fine I can silently approve it.

That would be appreciated.

@HansOlsson HansOlsson merged commit a5fdf17 into modelica:master Apr 21, 2020
@HansOlsson HansOlsson deleted the NewLatexML branch April 21, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LaTeX Issue with the LaTeX code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants