Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change notation for mass flow rate from \dot{m} to \tilde{m}. #2645

Merged
merged 3 commits into from Oct 5, 2020

Conversation

HansOlsson
Copy link
Collaborator

The reason is that it's the sum of mass flow rates that give \dot{m}
and the terms are not mass-derivatives.
Closes #2644

The reason is that it's the sum of mass flow rates that give \dot{m}
and the terms are not mass-derivatives.
Closes modelica#2644
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think we want an approval on this from a stream connector expert.

chapters/derivationofstream.tex Outdated Show resolved Hide resolved
@@ -5,21 +5,22 @@ \chapter{Derivation of Stream Equations}\label{derivation-of-stream-equations}

\section{Reasons for avoiding the actual mixing enthalpy in connector definitions}\label{reasons-for-avoiding-the-actual-mixing-enthalpy-in-connector-definitions}

Consider a connection set with \emph{n} connectors. The mixing enthalpy
is defined by the mass balance
Consider a connection set with \emph{n} connectors, and for the mass flow rates use $\tilde{m}=\text{m\_flow}$.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the number of connectors typically denoted $N$ (upper case) in this chapter? (Just wondering; I can see that it is outside the scope of the present fix.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunately messier. The formulas use $n$ and the headings use $N$ (or N - I believe there was some issue with math in headings). There might be some exceptions. For now I view that as good enough and rationalize the N as heading-capitalization.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upper case symbols aren't only in headings: I think it starts here, followed by lots of other places in stream.tex:

For the following definition it is assumed that $N$ inside connectors \lstinline!$m_{j}$.c! ($j = 1, 2, \ldots, N$) and $M$ outside connectors \lstinline!$c_{k}$! ($k = 1, 2, \ldots, M$) belonging to the same connection set

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, it is ugly to use uppercase $N$ and $M$, so I'd be strongly in favor of going in the direction of $n$ and $m$, but don't know what conflicts that would cause.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see in the stream-chapter N and M are used in the Modelica code, but in this appendix that is mostly math $n$ and $m$ are used in the formulas and N and M in the heading.

I agree that $n$ and $m$ and also n and m would be more common, but will place that in another PR (it's primarily for the stream-chapter).

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
@HansOlsson
Copy link
Collaborator Author

Looks good to me, but I think we want an approval on this from a stream connector expert.

I agree that would be ideal.

@HansOlsson
Copy link
Collaborator Author

Looks good to me, but I think we want an approval on this from a stream connector expert.

I agree that would be ideal.

Friendly reminder: @hubertus65 @casella (if there are additional fluid-experts, please be vocal) do you agree with this PR using \tilde{m} instead of \dot{m} for m_flow (actually using m_flow would be distracting and require additional subscripts).

@HansOlsson
Copy link
Collaborator Author

We would still appreciate input from a fluid-expert, but we cannot wait too long for that - so if we don't hear anything from fluid-experts by next week I think we will have to manage without.

Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding approval, just so that @HansOlsson can proceed with this in case there is still no feedback from fluid experts in a week from now.

@casella
Copy link
Collaborator

casella commented Oct 2, 2020

Sorry for the delay, thermal engineers often use \dot{m} for mass flow rate. As a control engineer, I really hate that, because in the context of dynamical systems it seems that m is a state, never mind writing dynamic equations with inertial effects, which would become m with two dots.... I myself use w for the mass flow rate. I guess \tilde{m} would also be fine, in any case I don't think this is a big deal.

@HansOlsson HansOlsson merged commit b365c0a into modelica:master Oct 5, 2020
@HansOlsson HansOlsson deleted the Tilde branch October 5, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appendix D uses notation '\dot{m}' instead of 'm_flow'
3 participants