Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paraphrase complicated negated sentence #2703

Merged
merged 4 commits into from Feb 15, 2024

Conversation

phannebohm
Copy link
Contributor

No description provided.

@phannebohm
Copy link
Contributor Author

Conceptually, should this also extend to chains of more than two operator records like C->D->E->C?
(-> represents a constructor, so the described scenario is C->D->C)

Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just leaving a minor comment.

chapters/overloaded.tex Outdated Show resolved Hide resolved
@henrikt-ma
Copy link
Collaborator

Conceptually, should this also extend to chains of more than two operator records like C->D->E->C?
(-> represents a constructor, so the described scenario is C->D->C)

This looks like a good question to ask in a new issue.

@HansOlsson
Copy link
Collaborator

HansOlsson commented Nov 3, 2020

Since you are a new contributor we also want a signed Contributor's License Agreement, CLA (or being part of an organization having signed the CLA on your behalf). @GallLeo

Added - you can find it at: https://www.modelica.org/licenses/ModelicaAssociationCLA_1.1/view

@HansOlsson
Copy link
Collaborator

Conceptually, should this also extend to chains of more than two operator records like C->D->E->C?
(-> represents a constructor, so the described scenario is C->D->C)

I don't see how that could occur. Constructors do not allow implicit calls of multiple constructors, and for the operators they are at most binary so we only have two arguments.

@HansOlsson HansOlsson self-requested a review November 3, 2020 08:07
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but we need the CLA issue clarified.

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
@phannebohm
Copy link
Contributor Author

Change looks good, but we need the CLA issue clarified.

No problem, except how do I sign? 😅
I'm with the university of applied sciences in Bielefeld, they may have signed it.

@HansOlsson
Copy link
Collaborator

Change looks good, but we need the CLA issue clarified.

No problem, except how do I sign? 😅
I'm with the university of applied sciences in Bielefeld, they may have signed it.

I understand you have to sign https://www.modelica.org/licenses/ModelicaAssociationCLA_1.1/view and send it in some way
@GallLeo can you handle this?

@GallLeo
Copy link
Collaborator

GallLeo commented Nov 5, 2020

I checked and FH Bielefeld has not signed the MA CLA, so far.

Please hand in a signed scan to backoffice@modelica.org and on paper to
MA Backoffice
c/o LTX Simulation GmbH
Wohlfartstr. 21b
80939 München

In schedule B, please list the employees, which should be covered by the CLA (best by name, email address and Github User Name).
After we do have this signed version, the "point of contact" can simply add or remove employees by sending informal e-mail (this will update schedule B).

Copy link
Member

@eshmoylova eshmoylova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably also update the sentence on lines 164-166:

Without mixed operations expressions such as
c+d are only ambiguous if both conversion from C to D and back from D to
C are both available...

"both" used twice

chapters/overloaded.tex Outdated Show resolved Hide resolved
Co-authored-by: Elena Shmoylova <eshmoylova@users.noreply.github.com>
@HansOlsson
Copy link
Collaborator

I checked and FH Bielefeld has not signed the MA CLA, so far.

Please hand in a signed scan to backoffice@modelica.org and on paper to
MA Backoffice
c/o LTX Simulation GmbH
Wohlfartstr. 21b
80939 München

In schedule B, please list the employees, which should be covered by the CLA (best by name, email address and Github User Name).
After we do have this signed version, the "point of contact" can simply add or remove employees by sending informal e-mail (this will update schedule B).

Any update w.r.t. CLA?
@GallLeo @phannebohm

@MABackoffice
Copy link

MABackoffice commented Sep 28, 2021

Any update w.r.t. CLA? @GallLeo @phannebohm

Did check: no CLA received at Backoffice, yet.
I sent a reminder to Bernhard, just now.

Please note, that the link above to CLA document is broken after server move of modelica.org :/
Link to current MA CLA: https://github.com/modelica/ModelicaAssociationCLA/releases

@HansOlsson
Copy link
Collaborator

Still no CLA from Bielefeld as far I know. Reminder sent July 14th.

@HansOlsson
Copy link
Collaborator

Without CLA we cannot accept it.

@HansOlsson HansOlsson closed this Dec 1, 2023
@phannebohm
Copy link
Contributor Author

The HSBI (former FH Bielefeld) managed to sign the CLA finally. It should have arrived at the Backoffice or be there shortly. Can you reopen this PR or should I open a new one?

@HansOlsson HansOlsson reopened this Feb 15, 2024
@HansOlsson
Copy link
Collaborator

Have finally gotten CLA.

@HansOlsson HansOlsson self-requested a review February 15, 2024 16:41
@HansOlsson HansOlsson merged commit bd990bc into modelica:master Feb 15, 2024
1 check passed
@phannebohm phannebohm deleted the phannebohm-patch-1 branch February 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants