New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paraphrase complicated negated sentence #2703
Conversation
Conceptually, should this also extend to chains of more than two operator records like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just leaving a minor comment.
This looks like a good question to ask in a new issue. |
Since you are a new contributor we also want a signed Contributor's License Agreement, CLA (or being part of an organization having signed the CLA on your behalf). @GallLeo Added - you can find it at: https://www.modelica.org/licenses/ModelicaAssociationCLA_1.1/view |
I don't see how that could occur. Constructors do not allow implicit calls of multiple constructors, and for the operators they are at most binary so we only have two arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, but we need the CLA issue clarified.
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
No problem, except how do I sign? 😅 |
I understand you have to sign https://www.modelica.org/licenses/ModelicaAssociationCLA_1.1/view and send it in some way |
I checked and FH Bielefeld has not signed the MA CLA, so far. Please hand in a signed scan to backoffice@modelica.org and on paper to In schedule B, please list the employees, which should be covered by the CLA (best by name, email address and Github User Name). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably also update the sentence on lines 164-166:
Without mixed operations expressions such as
c+d are only ambiguous if both conversion from C to D and back from D to
C are both available...
"both" used twice
Co-authored-by: Elena Shmoylova <eshmoylova@users.noreply.github.com>
Any update w.r.t. CLA? |
Did check: no CLA received at Backoffice, yet. Please note, that the link above to CLA document is broken after server move of modelica.org :/ |
Still no CLA from Bielefeld as far I know. Reminder sent July 14th. |
Without CLA we cannot accept it. |
The HSBI (former FH Bielefeld) managed to sign the CLA finally. It should have arrived at the Backoffice or be there shortly. Can you reopen this PR or should I open a new one? |
Have finally gotten CLA. |
No description provided.