Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colon instead of dash when attaching 'th' to ordinals #2793

Merged
merged 3 commits into from Jan 8, 2021

Conversation

henrikt-ma
Copy link
Collaborator

@henrikt-ma henrikt-ma commented Jan 1, 2021

Fixing issue reported by @HansOlsson in a comment to the recently merged #2789. Fixing this generally: one more case besides the originally reported listing.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I realized that colon here is Swedish (also when using numbers, e.g.: 1:a, 2:a, 3:e for 1st, 2nd, 3rd - Donald S. MacQueen "Using Numbers in English").

The English variants are i-th, i'th, and usually just ith (with i in italic mathematical style) https://en.wiktionary.org/wiki/ith
Looking more closely I believe the problem is that the problem might be that the hyphen in the comment text looks too long (due to the fixed-width font).
Using ith (with i in math-style) or i'th when we cannot change style might be the best; or possibly just ith in the latter case.

@henrikt-ma
Copy link
Collaborator Author

Good research. If the one without anything in between is the more common, it sounds like this is what we should try, unless we conclude that this doesn't work in listing comments, give priority to consistency over common style…

Did you figure out if there was a clear winner between hyphen and apostrophe, comparing commonality in technical literature?

@HansOlsson
Copy link
Collaborator

Seems it is difficult to search for that (even on GitHub) - both automatically and manually.
The only one I found so far was Graham, Knuth, Patashnik "Concrete Mathematics" that use kth on page 23, with slightly different font for "k" (but not an italic font - just slightly different one).

@henrikt-ma
Copy link
Collaborator Author

Seems it is difficult to search for that (even on GitHub) - both automatically and manually.
The only one I found so far was Graham, Knuth, Patashnik "Concrete Mathematics" that use kth on page 23, with slightly different font for "k" (but not an italic font - just slightly different one).

Then I suggest we go for k th (without that space necessitated by GitHub markdown) where math font is available, and k'th in listing comments. OK?

@HansOlsson
Copy link
Collaborator

Seems it is difficult to search for that (even on GitHub) - both automatically and manually.
The only one I found so far was Graham, Knuth, Patashnik "Concrete Mathematics" that use kth on page 23, with slightly different font for "k" (but not an italic font - just slightly different one).

Then I suggest we go for k th (without that space necessitated by GitHub markdown) where math font is available, and k'th in listing comments. OK?

Yes.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@HansOlsson HansOlsson merged commit 30e5363 into modelica:master Jan 8, 2021
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants