Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use comments instead of text escape in array indexing listing #2789

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Use comments instead of text escape in array indexing listing #2789

merged 2 commits into from
Dec 31, 2020

Conversation

henrikt-ma
Copy link
Collaborator

This makes the example more aligned with other examples, and thereby easier to read and understand.

@henrikt-ma
Use comments instead of text escape in array indexing listing
d7fc47e 
This makes the example more aligned with other examples, and thereby easier to read and understand.
HansOlsson
HansOlsson reviewed Dec 29, 2020
View reviewed changes
chapters/arrays.tex Outdated Show resolved Hide resolved
HansOlsson
HansOlsson requested changes Dec 29, 2020
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor mistake, but otherwise good.

HansOlsson
HansOlsson approved these changes Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for the moment. Looking at the text I see that "j--th" looks a bit odd (pre-existing issue), and maybe "j:th" would be better for the future.

@HansOlsson HansOlsson merged commit 565eb1f into modelica:master Dec 31, 2020
@henrikt-ma henrikt-ma deleted the cleanup/array-indexing-listing branch December 31, 2020 21:57
@henrikt-ma henrikt-ma mentioned this pull request Jan 1, 2021
Merged
@HansOlsson HansOlsson added M36 For pull requests merged into Modelica 3.6 and removed M36 For pull requests merged into Modelica 3.6 labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrikt-ma @HansOlsson