Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain abs no event #3202

Merged
merged 7 commits into from
Sep 6, 2022
Merged

Explain abs no event #3202

merged 7 commits into from
Sep 6, 2022

Conversation

HansOlsson
Copy link
Collaborator

Based on discussion in #3200

@HansOlsson HansOlsson added the clarification Specification of feature is unclear, but not incorrect label Jun 14, 2022
henrikt-ma
henrikt-ma requested changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, but I think we can give the reasons with some more detail for the readers that don't like figuring out too much on their own.

HansOlsson and others added 4 commits August 30, 2022 13:33
@HansOlsson @henrikt-ma
Update chapters/operatorsandexpressions.tex
11567f5 
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
@HansOlsson @henrikt-ma
Update chapters/operatorsandexpressions.tex
2abb214 
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
@HansOlsson
Change so that we don't say that there are always discontinuities, an…
ab15ebf 
…d explain for example.
@HansOlsson
FixLatex
a96f0af
henrikt-ma
henrikt-ma approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I was deeply involved in the current formulations, so my review should be considered rather biased.

@HansOlsson HansOlsson merged commit 987fd43 into modelica:master Sep 6, 2022
@HansOlsson HansOlsson deleted the ExplainAbsNoEvent branch September 6, 2022 22:02
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikt-ma henrikt-ma henrikt-ma approved these changes

Assignees
No one assigned
Labels
clarification Specification of feature is unclear, but not incorrect M36 For pull requests merged into Modelica 3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HansOlsson @henrikt-ma