Sentence-based line breaks for annotations #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
force-pushed
the
bugfix/connection-text-filledshape
branch
from
d11f53b
to
b5e84bf
Compare
|
After rebasing on top of the changes from #3513, only transition to sentence-based line breaks remain. Even though the issue has already been fixed, I think we should take this opportunity to get the line breaks right in the chapter. |
Ok, but then the name of the PR should then be changed. |
HansOlsson
requested changes
Jun 4, 2024
HansOlsson
changed the title
|
I changed the name of the PR, please confirm @henrikt-ma |
HansOlsson
approved these changes
Jun 11, 2024
It's a great new name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3512. The fix is the same as in #3513, but with separate transition to sentence-based line breaks.