-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentence-based line breaks for annotations #3514
Sentence-based line breaks for annotations #3514
Conversation
d11f53b
to
b5e84bf
Compare
After rebasing on top of the changes from #3513, only transition to sentence-based line breaks remain. Even though the issue has already been fixed, I think we should take this opportunity to get the line breaks right in the chapter. |
Ok, but then the name of the PR should then be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename PR as it is just line-break changes.
I changed the name of the PR, please confirm @henrikt-ma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok now, with new name
It's a great new name. |
Fixes #3512. The fix is the same as in #3513, but with separate transition to sentence-based line breaks.