Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superfluous parameter n in Rankine/Fahrenheit conversion #1202

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 6 comments · Fixed by #2887
Closed

Superfluous parameter n in Rankine/Fahrenheit conversion #1202

modelica-trac-importer opened this issue Jan 14, 2017 · 6 comments · Fixed by #2887
Assignees
@beutlich
Labels
L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer P: low Low priority issue
Milestone
MSL4.0.0

Comments

@modelica-trac-importer
Copy link

Reported by beutlich on 11 Jul 2013 07:34 UTC
What is HeatTransfer.Rankine.ToKelvin.n and HeatTransfer.Rankine.FromKelvin.n needed for? Seems not needed to me.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1202
@modelica-trac-importer modelica-trac-importer added this to the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by beutlich on 11 Jul 2013 10:25 UTC
Also in HeatTransfer.Fahrenheit.FromKelvin.n.

@modelica-trac-importer modelica-trac-importer changed the title Superfluous parameter n in Rankine conversion Superfluous parameter n in Rankine/Fahrenheit conversion Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by otter on 11 Jul 2013 12:05 UTC
Fixed in b82b207:

You are right, the parameter should be removed (seems to be an oversight).
For backwards compatibility the parameter cannot be removed since a user might already provide a modifier in a user model.
Instead, added an annotation (Dialg(enable=false)) to disable the parameter input field and changed the description text to point out that this variable is only supplied for backwards compatibility and will be removed in the future

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 11 Jul 2013 12:08 UTC
Leave this ticket open until the issue is finally resolved once an MSL with conversion script will be released.

@modelica-trac-importer modelica-trac-importer removed this from the MSL3.2.1 milestone Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Modified by otter on 18 Jul 2013 11:57 UTC

@modelica-trac-importer modelica-trac-importer added the P: low Low priority issue label Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:36 UTC
Milestone renamed

@modelica-trac-importer
Copy link
Author

Comment by dietmarw on 1 Aug 2015 21:39 UTC
Milestone renamed

@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MAJOR-version milestone Jan 14, 2017
@AHaumer AHaumer removed their assignment Jan 4, 2018
@beutlich beutlich mentioned this issue Jan 22, 2018
Closed
@beutlich beutlich self-assigned this Apr 8, 2019
@beutlich beutlich removed the bug Critical/severe issue label Apr 8, 2019
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Apr 8, 2019
@beutlich
refs modelica#1202: Remove unused parameter
05b3fc9
@beutlich beutlich mentioned this issue Apr 8, 2019
Merged
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue May 13, 2019
@beutlich
refs modelica#1202: Remove unused parameter
6d10a9d
beutlich added a commit that referenced this issue May 13, 2019
@beutlich
refs #1202: Remove unused parameter (#2887)
7b93b13
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@beutlich
refs modelica#1202, modelica#2226, modelica#2465: Document backwards-…
71ab327 
…compatibility breaking changes
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 15, 2019
@beutlich
refs modelica#1202, modelica#2226, modelica#2468: Document backwards-…
0463f77 
…compatibility breaking changes
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 23, 2019
@beutlich
refs modelica#1202, modelica#2226, modelica#2468: Document backwards-…
dc4fd39 
…compatibility breaking changes
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Jul 27, 2019
@beutlich
refs modelica#1202, modelica#2226, modelica#2468: Document backwards-…
c12d53b 
…compatibility breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
L: Thermal.HeatTransfer Issue addresses Modelica.Thermal.HeatTransfer P: low Low priority issue
Projects
None yet
Milestone
MSL4.0.0
3 participants
@AHaumer @beutlich @modelica-trac-importer