Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of CubicInterpolation_DP() und CubicInterpolation_MFLOW() are misleading #2006

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 6 comments · Fixed by #2780
Closed
Assignees
Labels
L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation task General work that is not related to a bug or feature
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by wischhusen on 6 Jun 2016 07:42 UTC
Modelica.Fluid.Dissipation.Utilities.Functions.General.CubicInterpolation_DP() calculates a Reynolds number from other Re-inputs but does not take a pressure difference as input
Modelica.Fluid.Dissipation.Utilities.Functions.General.CubicInterpolation_MFLOW() calculates a lambda but does not take a mass flow as input


Migrated-From: https://trac.modelica.org/Modelica/ticket/2006

@modelica-trac-importer modelica-trac-importer added the task General work that is not related to a bug or feature label Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Modified by beutlich on 14 Sep 2016 19:05 UTC

@modelica-trac-importer modelica-trac-importer added the L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation label Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Modified by beutlich on 14 Sep 2016 19:06 UTC

@wischhusen
Copy link
Contributor

How to auto-convert models that have function calls where the name or path of the function has changed? It seems that convertClass() should somehow have the functionality. But it does not work in my tool.

equation Re=Modelica.Fluid.Dissipation.Utilities.Functions.General.CubicInterpolation_MFLOW(1, 2, 3, 4, 5);

If we change the name of the function how can we convert the call in user libraries?

@beutlich
Copy link
Member

If we change the name of the function how can we convert the call in user libraries?

@HansOlsson Is it generally possible?

@HansOlsson
Copy link
Contributor

If we change the name of the function how can we convert the call in user libraries?
@HansOlsson Is it generally possible?

Yes, convertClass should convert function calls as well (the specification just discusses converting classes so it should be covered, and Dymola has implemented it). I don't know if there is a specific issue in this case.

@wischhusen
Copy link
Contributor

We can give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Fluid.Dissipation Issue addresses Modelica.Fluid.Dissipation task General work that is not related to a bug or feature
Projects
None yet
5 participants