Renaming of functions CubicInterpolation_DP and CubicInterpolation_MFLOW

[wischhusen]

close #2006

[beutlich]

Note, this only can be merged to master branch (targeting the next major release), once MSL v3.2.3 is released.

[beutlich]

@wischhusen Can you please provide a unit test (say ModelicaTest.Fluid.Dissipation.ConversionTest.'#2780') where conversion actually takes place? Thanks!

[wischhusen]

Added the conversion scirpt to Modelica/Resources/Scripts/Dymola and a Tester (Issue2780) to ModelicaTest.Fluid.Dissipation.ConversionTest.

I'm a bit puzzled about the correct version numbers for the change. It should be 3.2.4, right?

[dietmarw]

The next version is 4.0.0

[wischhusen]

Ok, so the Dymola conversion script should be named
ConvertModelica_from_3.2.3_to_4.0.0.mos ?

[dietmarw]

Exactly. 👍

[wischhusen]

Done

[dietmarw]

Please do not push branches to the MSL repository but use your own fork for that. Also the last correction is not present in the PR here. So you might have pushed to the wrong place.

[wischhusen]

There should be a branch issue2780. Anyhow, if that cannot be merged I will proceed with the fork.

[dietmarw]

Yes best to make a new PR based on a branch from your fork and also make sure that there is a test model in ModelicaTest that would trigger that conversion.

[dietmarw]

I was wondering if the location Scripts/Dymola is still the appropriate one since the conversion script is standardised for MLS 3.4 so in MSL 4.0.0 the standard script should probably be placed directly under Scripts?
@beutlich ?

[beutlich]

I was wondering if the location Scripts/Dymola is still the appropriate one since the conversion script is standardised for MLS 3.4 so in MSL 4.0.0 the standard script should probably be placed directly under Scripts?

See #2819 for the corresponding PR.

[beutlich]

Sorry for using this PR as guinea pig for the conversion. We will care for the proper location of the conversion script and the conversion tester.

[beutlich]

This is an important PR since it adds ConvertModelica_from_3.2.3_to_4.0.0.mos and ModelicaTestConversion4.mo, which all other issues requiring conversion depend on.

@hubertus65 Can you please run the merge.

[beutlich]

@hubertus65 Can you please run the merge.

Friendly reminder.

[hubertus65]

I have been traveling quite a bit. I'll try to find some block time for this. Any other tasks for me I missed?

[beutlich]

Any other tasks for me I missed?

Yes, also #2816 and #2818 await your review.

[HansOlsson]

Looks good.
I noticed one minor issue - but it isn't really part of this PR so I believe that should be a separate PR.

The minor issue is that conversion from MSL 2 could specify to="3.2.3"; so that the libraries using MSL 2 could be converted to MSL 4. (Which is super-rare and those conversions weren't changed anyway.)

[dietmarw]

The minor issue is that conversion from MSL 2 could specify to="3.2.3"; so that the libraries using MSL 2 could be converted to MSL 4. (Which is super-rare and those conversions weren't changed anyway.)
I discussed this with @beutlich and decided against including MSL 2 conversions since as far as I know, most of the current tools don't even support MSL 2 anymore. So no point.