Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modeling of Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator #2017

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 3 comments
Closed

Modeling of Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator #2017

modelica-trac-importer opened this issue Jan 15, 2017 · 3 comments
Assignees
@AHaumer @beutlich @kristinmajetta @ECClauss
Labels
bug Critical/severe issue example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Milestone
MSL3.2.3

Comments

@modelica-trac-importer
Copy link

Reported by efredriksson on 21 Jun 2016 07:55 UTC
I have a question regarding the model SignalGenerator. Running the model in multiple tools result in that we have one state c.v with discontinuous first derivative. The discontinuities wouldn't be a problem if they where associated with events but in this model, there are no event generating expressions. So my question is if this is an appropriate model?

Attached is a figure of the state and state derivative. Notice the jumps in the derivative and that there are no events in this model.

Migrated-From: https://trac.modelica.org/Modelica/ticket/2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog labels Jan 15, 2017
@dietmarw
Copy link
Member

image

@dietmarw dietmarw removed their assignment Jan 16, 2017
@beutlich beutlich changed the title Modeling of MSL.Electrical.Analog.OpAmps.SignalGenerator Modeling of Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator Mar 28, 2017
@beutlich
Copy link
Member

I believe it could be improved if Modelica.Electrical.Analog.Ideal.IdealizedOpAmpLimted models the limiter the same way as Modelica.Blocks.Nonlinear.Limiter.

@beutlich beutlich added this to the MSL_next-MINOR-version milestone Jun 16, 2017
@beutlich beutlich mentioned this issue Aug 22, 2017
Closed
beutlich added a commit that referenced this issue Oct 14, 2017
@beutlich
refs #2017, #2270: Add state events for voltage saturation
9d5bc99 
See Modelica.Blocks.Nonlinear.Limiter for the best practice of limiter modeling with state events
@beutlich beutlich self-assigned this Oct 14, 2017
@beutlich
Copy link
Member

beutlich commented Oct 14, 2017 •
edited
Loading

@efredriksson-modelon After 9d5bc99 Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator generates 20 state events for the voltage saturation.

@beutlich beutlich added the example Issue only addresses example(s) label May 28, 2018
@casella casella mentioned this issue May 30, 2018
Merged
@beutlich beutlich mentioned this issue Jun 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AHaumer AHaumer

@beutlich beutlich

@kristinmajetta kristinmajetta

@ECClauss ECClauss

Labels
bug Critical/severe issue example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
6 participants
@dietmarw @AHaumer @beutlich @kristinmajetta @modelica-trac-importer @ECClauss