New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling of Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator #2017

Closed
modelica-trac-importer opened this Issue Jan 15, 2017 · 3 comments

Comments

@modelica-trac-importer
Copy link

modelica-trac-importer commented Jan 15, 2017

Reported by efredriksson on 21 Jun 2016 07:55 UTC
I have a question regarding the model SignalGenerator. Running the model in multiple tools result in that we have one state c.v with discontinuous first derivative. The discontinuities wouldn't be a problem if they where associated with events but in this model, there are no event generating expressions. So my question is if this is an appropriate model?

Attached is a figure of the state and state derivative. Notice the jumps in the derivative and that there are no events in this model.


Migrated-From: https://trac.modelica.org/Modelica/ticket/2017

@dietmarw

This comment has been minimized.

Copy link
Member

dietmarw commented Jan 16, 2017

image

@dietmarw dietmarw removed their assignment Jan 16, 2017

@beutlich beutlich changed the title Modeling of MSL.Electrical.Analog.OpAmps.SignalGenerator Modeling of Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator Mar 28, 2017

@beutlich

This comment has been minimized.

Copy link
Member

beutlich commented Mar 28, 2017

I believe it could be improved if Modelica.Electrical.Analog.Ideal.IdealizedOpAmpLimted models the limiter the same way as Modelica.Blocks.Nonlinear.Limiter.

@beutlich beutlich added this to the MSL_next-MINOR-version milestone Jun 16, 2017

beutlich added a commit that referenced this issue Oct 14, 2017

refs #2017, #2270: Add state events for voltage saturation
See Modelica.Blocks.Nonlinear.Limiter for the best practice of limiter modeling with state events

@beutlich beutlich removed the hacktoberfest label Oct 14, 2017

@beutlich beutlich self-assigned this Oct 14, 2017

@beutlich

This comment has been minimized.

Copy link
Member

beutlich commented Oct 14, 2017

@efredriksson-modelon After 9d5bc99 Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator generates 20 state events for the voltage saturation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment