Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modelica.StateGraph.PartialCompositeStep.OuterState is not balanced #2028

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 1 comment · Fixed by #3136
Closed

Modelica.StateGraph.PartialCompositeStep.OuterState is not balanced #2028

modelica-trac-importer opened this issue Jan 15, 2017 · 1 comment · Fixed by #3136
Assignees
@dietmarw
Labels
bug Critical/severe issue L: StateGraph Issue addresses Modelica.StateGraph
Milestone
MSL4.0.0

Comments

@modelica-trac-importer
Copy link

Reported by hansolsson on 14 Jul 2016 13:20 UTC
Modelica.StateGraph.PartialCompositeStep.OuterState has a connector with 2 input Reals, 1 non-flow Real, 1 flow Real - and no equations, i.e. one equation is missing.

A solution is to make "active" an input and move

  outerState.subgraphStatePort.activeSteps = if active then 1.0 else 0.0;

from Modelica.StateGraph.PartialCompositeStep to Modelica.StateGraph.PartialCompositeStep.OuterState, and in some way connect/propagate active to this sub-component.

It is an internal class that should not be used by any other models.

Migrated-From: https://trac.modelica.org/Modelica/ticket/2028
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: StateGraph Issue addresses Modelica.StateGraph labels Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Comment by hansolsson on 15 Jul 2016 07:55 UTC
Same issue in: Modelica.StateGraph.Interfaces.PartialStep.OuterStatePort

@beutlich beutlich added this to the MSL_next-MINOR-version milestone Aug 21, 2017
dietmarw added a commit to dietmarw/ModelicaStandardLibrary that referenced this issue Oct 7, 2019
@dietmarw
Fixes modelica#2028 by adding balance equation.
6f5018e
@beutlich beutlich assigned dietmarw and unassigned MartinOtter Oct 8, 2019
@dietmarw dietmarw mentioned this issue Oct 8, 2019
Merged
beutlich pushed a commit to beutlich/ModelicaStandardLibrary that referenced this issue Oct 8, 2019
@dietmarw @beutlich
Fix modelica#2028 by adding balance equation
cf21693
@beutlich beutlich mentioned this issue Oct 8, 2019
Merged
beutlich added a commit that referenced this issue Oct 9, 2019
@beutlich
Fix #2028 by adding balance equation (#3141)
7e7d28f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dietmarw dietmarw

Labels
bug Critical/severe issue L: StateGraph Issue addresses Modelica.StateGraph
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Fix #2028 by adding balance equation dietmarw/ModelicaStandardLibrary
4 participants
@dietmarw @MartinOtter @beutlich @modelica-trac-importer