Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2028 by adding balance equation #3136

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Fix #2028 by adding balance equation #3136

merged 1 commit into from
Oct 8, 2019

Conversation

dietmarw
Copy link
Member

@dietmarw dietmarw commented Oct 7, 2019 •
edited by beutlich

Fix #2028.

@dietmarw dietmarw self-assigned this Oct 7, 2019
@dietmarw dietmarw added the L: StateGraph Issue addresses Modelica.StateGraph label Oct 7, 2019
@beutlich beutlich changed the title Fixes #2028 by adding balance equation. Fixes #2028 by adding balance equation Oct 7, 2019
@dietmarw dietmarw added this to the MSL4.0.0 milestone Oct 7, 2019
HansOlsson
HansOlsson approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems to check and simulate.

@beutlich beutlich merged commit ee73504 into modelica:master Oct 8, 2019
@beutlich beutlich added the bug Critical/severe issue label Oct 8, 2019
@beutlich beutlich mentioned this pull request Oct 8, 2019
Merged
@beutlich beutlich changed the title Fixes #2028 by adding balance equation Fix #2028 by adding balance equation Oct 8, 2019
@dietmarw dietmarw deleted the t2050-fixUnbalancedStep branch October 9, 2019 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@dietmarw dietmarw

Labels
bug Critical/severe issue L: StateGraph Issue addresses Modelica.StateGraph
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Modelica.StateGraph.PartialCompositeStep.OuterState is not balanced
3 participants
@dietmarw @HansOlsson @beutlich