Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter names of frequency sweep sources from fMin and fMax to fStart and fStop #2453

Closed
christiankral opened this issue Jan 29, 2018 · 0 comments
Assignees
Labels
enhancement New feature or enhancement L: Electrical.QuasiStationary Issue addresses Modelica.Electrical.QuasiStationary
Milestone

Comments

@christiankral
Copy link
Contributor

In #2452 the frequency sweep behavior has been changed, such that the following cases are now allowed in model Modelica.ComplexBlocks.Sources.LogFrequencySweep:

  • wMin < wMax
  • wMin == wMax
  • wMin > wMax

As a consequence of this change, it makes sense to rename the parameters of the newly models, since this is NO backwards compatibility issue:

  • Modelica.Electrical.QuasiStationary.SinglePhase.Sources.FrequencySweepVoltageSource
  • Modelica.Electrical.QuasiStationary.SinglePhase.Sources.FrequencySweepCurrentSource
  • Modelica.Electrical.QuasiStationary.MultiPhase.Sources.FrequencySweepVoltageSource
  • Modelica.Electrical.QuasiStationary.MultiPhase.Sources.FrequencySweepCurrentSource

Change from

  parameter Modelica.SIunits.Frequency fMin(start=1) "Lower sweep frequency";
  parameter Modelica.SIunits.Frequency fMax(start=1) "Upper sweep frequency";

to

  parameter Modelica.SIunits.Frequency fStart(final min=eps, start=1) "Start sweep frequency";
  parameter Modelica.SIunits.Frequency fStop(final min=eps, start=1) "Stop sweep frequency";
@christiankral christiankral self-assigned this Jan 29, 2018
@christiankral christiankral added enhancement New feature or enhancement L: Electrical.QuasiStationary Issue addresses Modelica.Electrical.QuasiStationary labels Jan 29, 2018
@christiankral christiankral added this to the MSL_next-MINOR-version milestone Jan 29, 2018
@christiankral christiankral changed the title Change parameter names of frequency sweep sources from wMin and wMax to wStart and wStop Change parameter names of frequency sweep sources from fMin and fMax to fStart and fStop Jan 29, 2018
@beutlich beutlich modified the milestones: MSL_next-MINOR-version, MSL3.2.3 Jan 29, 2018
@beutlich beutlich changed the title Change parameter names of frequency sweep sources from fMin and fMax to fStart and fStop Change parameter names of frequency sweep sources from fMin and fMax to fStart and fStop Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement L: Electrical.QuasiStationary Issue addresses Modelica.Electrical.QuasiStationary
Projects
None yet
Development

No branches or pull requests

2 participants