Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid reference to T_heatPort in line models #3096

Closed
beutlich opened this issue Aug 18, 2019 · 0 comments · Fixed by #3138
Closed

Invalid reference to T_heatPort in line models #3096

beutlich opened this issue Aug 18, 2019 · 0 comments · Fixed by #3138
Assignees
@dietmarw
Labels
documentation Issue addresses the documentation L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Milestone
MSL4.0.0

Comments

@beutlich
Copy link
Member

The three line models Modelica.Electrical.Analog.Lines.{OLine, M_OLine, ULine} mention T_heatPort in their parameter descriptions and documentation though there is no such variable.
@beutlich beutlich added L: Electrical.Analog Issue addresses Modelica.Electrical.Analog documentation Issue addresses the documentation labels Aug 18, 2019
@beutlich beutlich added this to the MSL4.0.0 milestone Aug 18, 2019
christiankral added a commit to christiankral/ModelicaStandardLibrary that referenced this issue Aug 26, 2019
@christiankral
Refs modelica#3096: Fix undocumented variable T_heatPort
ad974a1 
In order to be more precise, T_heatPort is replaced by T_actual and T_actual is explained in the text, as this is mainly a documentation and not a code issue
dietmarw added a commit to dietmarw/ModelicaStandardLibrary that referenced this issue Oct 7, 2019
@dietmarw
Fixes modelica#3096 by replacing T_heatPort with heatPort.T in docume…
bde66ed 
…ntation.
@beutlich beutlich assigned dietmarw and unassigned christophclauss Oct 8, 2019
@dietmarw dietmarw mentioned this issue Oct 9, 2019
Merged
beutlich pushed a commit that referenced this issue Oct 9, 2019
@dietmarw @beutlich
Fix #3096 by replacing T_heatPort with heatPort.T in documentation (#…
0167c19 
…3138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dietmarw dietmarw

Labels
documentation Issue addresses the documentation L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging a pull request may close this issue.

Fix #3096 by replacing T_heatPort with heatPort.T in documentation dietmarw/ModelicaStandardLibrary
3 participants
@dietmarw @beutlich @christophclauss