Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3096 by replacing T_heatPort with heatPort.T in documentation #3138

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fix #3096 by replacing T_heatPort with heatPort.T in documentation #3138

merged 1 commit into from
Oct 9, 2019

Conversation

dietmarw
Copy link
Member

@dietmarw dietmarw commented Oct 7, 2019 •
edited by beutlich

Fix #3096.

@dietmarw dietmarw self-assigned this Oct 7, 2019
@dietmarw dietmarw added the L: Electrical.Analog Issue addresses Modelica.Electrical.Analog label Oct 7, 2019
@dietmarw dietmarw added this to the MSL4.0.0 milestone Oct 7, 2019
beutlich
beutlich reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #3101?

@dietmarw
Copy link
Member Author

dietmarw commented Oct 8, 2019

It looks like it and I missed that one. But #3101 is actually broken since there is no T_actual and some typos are also present. So I'd rather use this one.

@dietmarw dietmarw mentioned this pull request Oct 8, 2019
Closed
@beutlich beutlich changed the title Fixes #3096 by replacing T_heatPort with heatPort.T in documentation. Fixes #3096 by replacing T_heatPort with heatPort.T in documentation Oct 8, 2019
@beutlich beutlich added the documentation Issue addresses the documentation label Oct 8, 2019
christiankral
christiankral approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@beutlich beutlich removed the request for review from AHaumer October 9, 2019 13:53
@beutlich beutlich changed the title Fixes #3096 by replacing T_heatPort with heatPort.T in documentation Fix #3096 by replacing T_heatPort with heatPort.T in documentation Oct 9, 2019
@beutlich beutlich merged commit 0167c19 into modelica:master Oct 9, 2019
@dietmarw dietmarw deleted the t3096-removeHeatPortReference branch October 9, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiankral christiankral christiankral approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@dietmarw dietmarw

Labels
documentation Issue addresses the documentation L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
MSL4.0.0
Development

Successfully merging this pull request may close these issues.

Invalid reference to T_heatPort in line models
3 participants
@dietmarw @christiankral @beutlich