Remove all occurrences of valign="top" from Documentation #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am aware that there are some additional usages of |
christiankral
approved these changes
Apr 26, 2018
The attribute `valign="top"` has no effect on any of the tables and therefore just adds noise to the HTML code which is then also harder to read. Also the attribute should not be added to `td` elements but rather defined via styles if really necessary.
beutlich
approved these changes
Apr 27, 2018
beutlich
changed the title
|
I noticed that valign="top" indeed looks better for broken long lines, as for example is recommended in Modelica.UsersGuide.Conventions.UsersGuide.References. Without valign: With valign="top": Another table that looked better with valign="top" is in Modelica.Mechanics.MultiBody.Examples.Elementary. |
beutlich
added a commit
to beutlich/ModelicaStandardLibrary
that referenced
this pull request
May 24, 2018
This reverts commit 5591ebc. # Conflicts: # Modelica/Math/package.mo # Modelica/Mechanics/MultiBody/Examples/Elementary/package.mo # Modelica/Mechanics/MultiBody/Examples/Loops/package.mo # Modelica/Mechanics/MultiBody/Forces.mo # Modelica/Mechanics/MultiBody/Frames.mo # Modelica/Mechanics/MultiBody/Joints.mo # Modelica/Mechanics/MultiBody/Parts.mo # Modelica/Mechanics/MultiBody/Types.mo # Modelica/Mechanics/MultiBody/Visualizers.mo # Modelica/Media/Water/IF97_Utilities.mo # Modelica/Utilities/Files.mo # Modelica/Utilities/Strings.mo # Modelica/package.mo
dietmarw
added a commit
to dietmarw/OMCompiler
that referenced
this pull request
May 25, 2018
During a documentation clean up of the MSL for 3.2.3 release the style seetings for vertical alignment were removed (modelica/ModelicaStandardLibrary#2517) Other tools (e.g., SimulationX and Dymola) have their own default settings that actually match top alignment. OMEdit is probably going to have the same. This PR adds this for the documentation generation.
dietmarw
added a commit
to dietmarw/OMCompiler
that referenced
this pull request
May 25, 2018
During a documentation clean up of the MSL for 3.2.3 release the style settings for vertical alignment were removed (modelica/ModelicaStandardLibrary#2517) Other tools (e.g., SimulationX and Dymola) have their own default settings that actually match top alignment. OMEdit is probably going to have the same. This PR adds this for the documentation generation.
OpenModelica-Hudson
pushed a commit
to OpenModelica/OMCompiler
that referenced
this pull request
May 25, 2018
During a documentation clean up of the MSL for 3.2.3 release the style settings for vertical alignment were removed (modelica/ModelicaStandardLibrary#2517) Other tools (e.g., SimulationX and Dymola) have their own default settings that actually match top alignment. OMEdit is probably going to have the same. This PR adds this for the documentation generation. Belonging to [master]: - #2467
beutlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute
valign="top"has no effect on any of the tables and therefore just adds noise to the HTML code which is then also harder to read.Also the attribute should not be added to
tdelements but rather defined via styles if really necessary.