Revert "Remove all occurences of valign=top (#2517)" #2546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5591ebc. # Conflicts: # Modelica/Math/package.mo # Modelica/Mechanics/MultiBody/Examples/Elementary/package.mo # Modelica/Mechanics/MultiBody/Examples/Loops/package.mo # Modelica/Mechanics/MultiBody/Forces.mo # Modelica/Mechanics/MultiBody/Frames.mo # Modelica/Mechanics/MultiBody/Joints.mo # Modelica/Mechanics/MultiBody/Parts.mo # Modelica/Mechanics/MultiBody/Types.mo # Modelica/Mechanics/MultiBody/Visualizers.mo # Modelica/Media/Water/IF97_Utilities.mo # Modelica/Utilities/Files.mo # Modelica/Utilities/Strings.mo # Modelica/package.mo
|
Actually I like to explore better alternatives here. |
|
Sure. CSS is the better and OO style way to go for. Unfortunately, nothing is yet specified and we would need to wait for modelica/ModelicaSpecification#1893 and new version of Modelica specification. |
|
Close as tool issue now, that can be solved in a tool-independet way once modelica/ModelicaSpecification#1893 is specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5591ebc.
As stated by #2517 (comment) there are tables where valign="top" has an effect. As it is rather tedious to figure out all tables with (long or explicit) line breaks, I'd rather propose to revert the changes of #2517.