Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify domain colors in ComplexBlocks #2977

Merged
merged 4 commits into from
Jun 21, 2019

Conversation

christiankral
Copy link
Contributor

@christiankral christiankral commented Jun 16, 2019

close #2833

@christiankral christiankral added enhancement New feature or enhancement L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath labels Jun 16, 2019
@christiankral christiankral added this to the MSL4.0.0 milestone Jun 16, 2019
@beutlich
Copy link
Member

This commit introduces large scale changes and I cannot judge if they are introduced intentionally or if they are noise.

@christiankral
Copy link
Contributor Author

This commit introduces large scale changes and I cannot judge if they are introduced intentionally or if they are noise.

I changed everything in a few commits.

I made no changes to the code format intentionally. Most noise is generated by Dymola automatically -- by a reason unknown to me. I checked the entire MSL and and the check is OK. If you checkout the branch and visually go through the models you will get a good impression of the changes.

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ComplexBlocks is now the only colored icon when expanding the Modelica root package. Please revert.

grafik

@christiankral
Copy link
Contributor Author

OK, I didn't notice.

@beutlich beutlich added task General work that is not related to a bug or feature and removed enhancement New feature or enhancement labels Jun 21, 2019
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@AHaumer AHaumer merged commit d1a73f4 into modelica:master Jun 21, 2019
@beutlich beutlich assigned AHaumer and unassigned beutlich Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Complex* Issue addresses Complex, Modelica.ComplexBlocks or Modelica.ComplexMath task General work that is not related to a bug or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "domain color" consequently in icons of ComplexMath
3 participants