-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save the CFLAGS already passed to the script #3580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is correct, but it was too long since I worked with such auto-tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to your comment "Save the CFLAGS already passed to the script" I'd rather expected ac_saved_cflags="$CFLAGS $1" in line 29.
That would refer to the CFLAGS passed to the configure script, not the modified macro |
Sorry, cannot follow. I cannot judge what was wrong before and what is fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK by me!
The last change to the lines was similar (e1c03f0), but didn't catch this other error