Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save the CFLAGS already passed to the script #3580

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Save the CFLAGS already passed to the script #3580

merged 1 commit into from
Nov 18, 2020

Conversation

sjoelund
Copy link
Member

The last change to the lines was similar (e1c03f0), but didn't catch this other error

HansOlsson
HansOlsson reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is correct, but it was too long since I worked with such auto-tools.

beutlich
beutlich reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your comment "Save the CFLAGS already passed to the script" I'd rather expected ac_saved_cflags="$CFLAGS $1" in line 29.

@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Jun 19, 2020
@sjoelund
Copy link
Member Author

That would refer to the CFLAGS passed to the configure script, not the modified macro

@beutlich
Copy link
Member

That would refer to the CFLAGS passed to the configure script, not the modified macro

Sorry, cannot follow. I cannot judge what was wrong before and what is fixed now.

@sjoelund sjoelund requested a review from adrpo November 18, 2020 07:59
@beutlich beutlich requested review from HansOlsson and adrpo and removed request for adrpo November 18, 2020 08:00
@beutlich beutlich added this to the MSL4.1.0 milestone Nov 18, 2020
adrpo
adrpo approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@adrpo adrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me!

@sjoelund sjoelund merged commit b1ec343 into modelica:master Nov 18, 2020
@sjoelund sjoelund deleted the save-cflags branch November 18, 2020 08:33
@beutlich beutlich removed the request for review from HansOlsson November 18, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson left review comments

@adrpo adrpo adrpo approved these changes

@beutlich beutlich beutlich approved these changes

Assignees

@sjoelund sjoelund

Labels
L: Resources Issue addresses Modelica/Resources (excl. C-Sources)
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjoelund @beutlich @adrpo @HansOlsson