Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelicaIO.c: Improve error message if reading text file containing zero bytes #3604

Merged
merged 2 commits into from
Jul 9, 2020
Merged

ModelicaIO.c: Improve error message if reading text file containing zero bytes #3604

merged 2 commits into from
Jul 9, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Jul 8, 2020

closes #3603

@beutlich beutlich added enhancement New feature or enhancement L: C-Sources Issue addresses Modelica/Resources/C-Sources labels Jul 8, 2020
@beutlich beutlich added this to the MSL4.1.0 milestone Jul 8, 2020
@beutlich beutlich self-assigned this Jul 8, 2020
@beutlich beutlich changed the title ModelicaIO.c: Improve error message if reading text file with zero bytes ModelicaIO.c: Improve error message if reading text file containing zero bytes Jul 9, 2020
HansOlsson
HansOlsson approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maltelenz
maltelenz approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I have not looked at the changes in .CI/Test, since I have no experience with that system.

@beutlich beutlich merged commit 403e9d0 into modelica:master Jul 9, 2020
@beutlich beutlich deleted the update-error-message branch July 9, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltelenz maltelenz maltelenz approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

Memory allocation error in CombiTimeTable when given UTF16 LE file
3 participants
@beutlich @maltelenz @HansOlsson