-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just use "redeclare" instead of "redeclare final" #3649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand but I'm not involved in Fluid, so maybe ask someone more famailiar with Fluid?
Sorry, I got confused, one issue involved the Machines-library in the Fluid-library, not the Electrical.Machines-library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look harmless to me, as they only remove the use of final
when redeclaring classes.
However, I am not sure exactly what problem is being solved here. My guess is that this is really just a matter of removing some final
that are believed to have been added for the wrong reason (namely, to make sure that the redeclaration isn't treated as redeclare replaceable
). If my guess is wrong, however, I am unable to tell whether the proposed removal of final
would have the desired effect, and it must be noted that the very meaning of a class being final is subject to ongoing discussion in #2719.
27377df
to
624de67
Compare
You mean modelica/ModelicaSpecification#2719 |
Off-topic: I'll care for a clean commit history w/o merge commits. |
Otherwise the class will be final which in some cases could lead to problems. modelica/ModelicaSpecification#2676
73d29a4
to
2365358
Compare
Done. |
Should this be back-ported to the maintenance branches? |
Yes. |
Otherwise the class will be final which in some cases lead to problems.
modelica/ModelicaSpecification#2676