Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start value to ensure convergence to the right flow in suddenExpansion1 #3657

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Add start value to ensure convergence to the right flow in suddenExpansion1 #3657

merged 1 commit into from
Nov 16, 2020

Conversation

casella
Copy link
Contributor

@casella casella commented Nov 4, 2020

Fixes #3656

@casella casella self-assigned this Nov 4, 2020
@casella casella added bug Critical/severe issue L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) labels Nov 4, 2020
@casella casella added this to the MSL4.0.1 milestone Nov 4, 2020
@beutlich beutlich added the example Issue only addresses example(s) label Nov 4, 2020
@beutlich beutlich modified the milestones: MSL4.0.1, MSL4.1.0 Nov 4, 2020
@beutlich beutlich removed their request for review November 15, 2020 20:16
@casella casella removed the request for review from hubertus65 November 16, 2020 10:31
@casella casella merged commit c23120c into modelica:master Nov 16, 2020
@beutlich beutlich mentioned this pull request Nov 16, 2020
Merged
@beutlich beutlich changed the title Added start value to ensure convergence to the right flow in suddenExpansion1 Add start value to ensure convergence to the right flow in suddenExpansion1 Jul 6, 2021
@casella casella mentioned this pull request Jun 20, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorade thorade thorade approved these changes

@mwetter mwetter mwetter approved these changes

Assignees

@casella casella

Labels
bug Critical/severe issue example Issue only addresses example(s) L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

The reference solution of Modelica.Fluid.Examples.Explanatory.MomentumBalanceFittings is wrong
4 participants
@casella @thorade @mwetter @beutlich