Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getcwd fallback in ModelicaInternal_fullPathName #3663

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Add getcwd fallback in ModelicaInternal_fullPathName #3663

merged 1 commit into from
Nov 17, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Nov 11, 2020 •
edited
Loading

Check if realpath fails for non-existing path and add getcwd fallback. Especially, do not call ModelicaError for non-existing path.

Closes #3660 for OM#6204.

@beutlich
refs modelica#3660: Add getcwd fallback in ModelicaInternal_fullPathName
7476879 
Check if realpath fails for non-existing path and add getcwd fallback. Especially, do not call ModelicaError for non-existing path.
@beutlich beutlich added bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources labels Nov 11, 2020
@beutlich beutlich added this to the MSL4.1.0 milestone Nov 11, 2020
@beutlich beutlich self-assigned this Nov 11, 2020
HansOlsson
HansOlsson approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.

sjoelund
sjoelund approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise you already fixed this. It was on my list for this week. I tested the code and it works fine.

@beutlich beutlich removed the request for review from casella November 17, 2020 16:26
@beutlich beutlich merged commit 3c50a41 into modelica:master Nov 17, 2020
@beutlich beutlich deleted the do-no-error-if-realpath-fails branch November 17, 2020 16:26
This was referenced Nov 17, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoelund sjoelund sjoelund approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

Modelica.Utilities.Files.createDirectory fails if the directory does not exist
3 participants
@beutlich @sjoelund @HansOlsson