Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tableOnFile parameter to icon of CombiTable blocks #3692

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add tableOnFile parameter to icon of CombiTable blocks #3692

merged 1 commit into from
Jan 14, 2021

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Dec 22, 2020 •
edited
Loading

This PR adds tableOnFile as the primary parameter to the icons of the table blocks.

@beutlich beutlich added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks icon Issues addresses the icon graphics labels Dec 22, 2020
@beutlich beutlich added this to the MSL4.1.0 milestone Dec 22, 2020
@beutlich beutlich self-assigned this Dec 22, 2020
HansOlsson
HansOlsson approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, even though most of the changes are just removing redundant ".0" - which possibly should be a separate PR.

@beutlich beutlich removed the request for review from AHaumer January 14, 2021 21:36
@beutlich beutlich merged commit 2e5c12e into modelica:master Jan 14, 2021
@beutlich beutlich deleted the update-icon branch January 14, 2021 21:46
@beutlich
Copy link
Member Author

Looks good, even though most of the changes are just removing redundant ".0" - which possibly should be a separate PR.

Right. See #3720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinOtter MartinOtter MartinOtter approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement icon Issues addresses the icon graphics L: Blocks Issue addresses Modelica.Blocks
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beutlich @MartinOtter @HansOlsson