Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize motion in x direction (r_rel_a_1) instead of in z (r_rel_a_3) #3712

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Initialize motion in x direction (r_rel_a_1) instead of in z (r_rel_a_3) #3712

merged 1 commit into from
Jan 14, 2021

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented Jan 12, 2021

close #3706

@tobolar tobolar added L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody example Issue only addresses example(s) labels Jan 12, 2021
@tobolar tobolar added this to the MSL4.1.0 milestone Jan 12, 2021
maltelenz
maltelenz approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In System Modeler, the model passes correctness against the reference result from 4.0.0 (which it also did before these changes). I did not look deeper to try to understand the model and the changes.

HansOlsson
HansOlsson approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't understand why we don't detect the error yet.
However, we detect another issue - will open issue.

@HansOlsson HansOlsson mentioned this pull request Jan 14, 2021
Merged
@tobolar tobolar merged commit 401ae88 into modelica:master Jan 14, 2021
@tobolar tobolar deleted the fix3706_PrismaticConstraintExample branch January 14, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltelenz maltelenz maltelenz approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees

@tobolar tobolar

Labels
example Issue only addresses example(s) L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Projects
None yet
Milestone
MSL4.1.0
3 participants
@tobolar @maltelenz @HansOlsson