Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FluidData.mo #3766

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Update FluidData.mo #3766

merged 1 commit into from
Oct 26, 2021

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Mar 6, 2021

  • Remove superfluous import of PartialMixtureMedium
  • Fix number of records from 37 to 38
  • Fix documentation (change spelling of "1-Heptane" to "1-Heptene", add "1-Butanol", fix columns (there is no such gas "Neon Oxygen"))
  • Add gas name as record description
  • Add IUPAC name where available (except CO2 and NO2)

However, I am wondering what the comment

hasAcentricFactor = true); // does not exist!

means and if the number of records should be 37. In any case, it should be clarified.

@beutlich beutlich added the L: Media Issue addresses Modelica.Media label Mar 6, 2021
@beutlich beutlich added this to the MSL4.1.0 milestone Mar 6, 2021
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel confident in reviewing this chemical changes - as I'm not familiar with IUPAC.
E.g., I don't understand if "Azane" for Ammonia (NH3) is the correct name to use here, or if it is only intended to be used in some cases.

@HansOlsson
Copy link
Contributor

I'm also a bit confused about 1-Heptene; as I understand it is https://en.wikipedia.org/wiki/Heptene is C7H14 but just called Heptene without the 1 - although iupacName is given as hept-1-ene.

And https://en.wikipedia.org/wiki/Ammonia state that

IUPAC name Ammonia
Systematic IUPAC name Azane

@MartinOtter MartinOtter removed their assignment Mar 8, 2021
@MartinOtter
Copy link
Member

MartinOtter commented Mar 8, 2021

I do not know enough about this topic to approve it. As I recall "hasAcentricFactor" was introduced by @hubertus65.

@beutlich
Copy link
Member Author

beutlich commented Mar 8, 2021

I took "azane" (and the other IUPAC names) frome pubchem. Could be that "ammonia" is more common in literature though.

@beutlich
Copy link
Member Author

However, I am wondering what the comment

hasAcentricFactor = true); // does not exist!

means and if the number of records should be 37. In any case, it should be clarified.

@hubertus65 @thorade I assume that comment is OK then, right?

@thorade
Copy link
Contributor

thorade commented May 20, 2021

Maybe the comment originally was in a different place?
Like this:

  constant Modelica.Media.Interfaces.Types.IdealGas.FluidConstants CO2(
                       chemicalFormula =        "CO2",
                       iupacName =              "unknown", // does not exist!
                       structureFormula =       "unknown",
                       casRegistryNumber =      "124-38-9",
                       meltingPoint =           216.58,
                       normalBoilingPoint =     -1.0,
                       criticalTemperature =    304.12,
                       criticalPressure =        73.74e5,
                       criticalMolarVolume =     94.07e-6,
                       acentricFactor =           0.225,
                       dipoleMoment =             0.0,
                       molarMass =              SingleGasesData.CO2.MM,
                       hasDipoleMoment =       true,
                       hasIdealGasHeatCapacity=true,
                       hasCriticalData =       true,
                       hasAcentricFactor =     true); 

I think Dymola would move that comment behind the semicolon in this case.
CO2 does exist :-)

* Remove superfluous import of PartialMixtureMedium
* Fix number of records from 37 to 38
* Fix documentation (change spelling of "1-Heptane" to "1-Heptene", add "1-Butanol", fix columns (there is no such gas "Neon Oxygen"))
* Add gas name as record description
* Add IUPAC name where available (except CO2 and NO2)
@beutlich
Copy link
Member Author

beutlich commented May 20, 2021

It has been in MSL like this since it first appeared.

There also is NO2 with iupacName = "unknown" and without that comment.

@hubertus65
Copy link
Member

The acentric factor is defined via the boiling point at atmospheric pressure, and therefore it actually doesn't exist for CO2. With that clarification, and all approvals, I think it can be merged.

@hubertus65 hubertus65 merged commit 369623b into modelica:master Oct 26, 2021
@beutlich beutlich deleted the update-fluid-data branch October 26, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Media Issue addresses Modelica.Media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants