Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State temperatures in PartialHeatTransfer declared as Medium-specific type #3802

Merged
merged 1 commit into from
May 20, 2021

Conversation

antoniofroio
Copy link
Contributor

State temperatures in the Modelica.Fluid.Interfaces.PartialHeatTransfer model are not Medium-specific, causing some tools (notably OpenModelica) to throw warnings concerning nominal and/or initial conditions

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2021

CLA assistant check
All committers have signed the CLA.

@beutlich beutlich added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label May 20, 2021
Copy link
Contributor

@thorade thorade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why OpenModelica complains really, but this change is a small improvement anyway.

@beutlich beutlich removed the request for review from MartinOtter May 20, 2021 17:02
@beutlich beutlich self-assigned this May 20, 2021
@beutlich beutlich added this to the MSL4.1.0 milestone May 20, 2021
@beutlich beutlich merged commit f0f65ea into modelica:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants