Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix M_Oline.segment as discussed in #3826 #3827

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Jun 4, 2021

Utilize Short with instance name M for backwards compatibility.
@dietmarw can you back-port this to maint/4.0.x (see #3818)?
I suppose after merging this PR and #3828 we should rebase #3819 or create a new PR.

@AHaumer AHaumer added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog labels Jun 4, 2021
@AHaumer AHaumer added this to the MSL4.0.1 milestone Jun 4, 2021
@dietmarw dietmarw modified the milestones: MSL4.0.1, MSL4.1.0 Jun 4, 2021
@dietmarw
Copy link
Member

dietmarw commented Jun 4, 2021

Just to explain (again) the change of milestone here: master is the next MINOR (or MAJOR). Any bugfix changes here will get backported to maint/4.0.x and need a separate PR once this one is merged.

Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AHaumer
Copy link
Contributor Author

AHaumer commented Jun 4, 2021

Just to explain (again) the change of milestone here: master is the next MINOR (or MAJOR). Any bugfix changes here will get backported to maint/4.0.x and need a separate PR once this one is merged.

Ok so no backport to 3.2.3?
Are you going to take care of backport to maint/4.0.x?

@dietmarw
Copy link
Member

dietmarw commented Jun 4, 2021

Ok so no backport to 3.2.3?

Not unless you do that manually. I have no interest and don't see the point of backporting this to 3.2.3. I would do it if it was a simple pick of the commits. But that is not possible since the file structure has changed quite a lot since then.

Are you going to take care of backport to maint/4.0.x?

Yes, already done. I just wait with the PR until this got successfully merged.

@AHaumer
Copy link
Contributor Author

AHaumer commented Jun 4, 2021

To be honest: I'd drop the back-port to 3.2.3 - @ditmarw what's your opinion?
It seems that @max-privato was the first user to complain about the Lines models, and a lot more issues came up when taking care of that (see #3828 and missing examples).

@dietmarw
Copy link
Member

dietmarw commented Jun 4, 2021

That's fine with me. I don't think it is a huge issue and as you said, this was the very first time it was raised. So I doubt that user models exist that are impacted by this. Any new users will most likely start with MSL 4.0.0 anyway where the bugfix will be available at some point.

by using fully qualified class names
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good

@AHaumer AHaumer merged commit 1a712a9 into modelica:master Jun 7, 2021
@beutlich beutlich assigned AHaumer and unassigned dietmarw Jun 7, 2021
dietmarw added a commit to dietmarw/ModelicaStandardLibrary that referenced this pull request Jun 7, 2021
dietmarw added a commit to dietmarw/ModelicaStandardLibrary that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants