Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wundef warning by first checking if macro is defined #3861

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

beutlich
Copy link
Member

As reported by @seanm in tbeu/matio#178.

@beutlich beutlich added the L: C-Sources Issue addresses Modelica/Resources/C-Sources label Aug 30, 2021
@beutlich beutlich added this to the MSL4.1.0 milestone Aug 30, 2021
@beutlich beutlich self-assigned this Aug 30, 2021
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2021

CLA assistant check
All committers have signed the CLA.

@beutlich beutlich enabled auto-merge (squash) August 30, 2021 17:08
Copy link
Member

@sjoelund sjoelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK. A bit unnecessary, but OK to be able to use -Wall.

Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, even if unnecessary as undefined potential macros are replaced by 0 here.

@beutlich
Copy link
Member Author

@seanm OK for you to sign the CLA?

@seanm
Copy link
Contributor

seanm commented Sep 7, 2021

@beutlich sorry for the delayed response, I was on vacation until today. Oof that's a lot of work for such a triviality... I've never even heard of Modelica, I thought I was patching matio, but I guess that file is actually from your project. Maybe it's easier if someone recreates the patch without my name associated...?

@beutlich beutlich merged commit 5b6db4f into modelica:master Sep 7, 2021
@beutlich beutlich deleted the stdc-warning branch September 7, 2021 18:28
@beutlich beutlich changed the title Fixed -Wundef warning by first checking if macro is defined Fix -Wundef warning by first checking if macro is defined Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants