Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerConverters.DCDC.HBridge #3897

Merged
merged 8 commits into from
Jan 19, 2022
Merged

PowerConverters.DCDC.HBridge #3897

merged 8 commits into from
Jan 19, 2022

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Nov 13, 2021

This PR is backwards compatible as discussed in #3895 and documented in DCDC.HBridge and DCDC.Control.SignalPWM.
The new layout of distributing the the fire signals in the HBridge allows an alternative pwm algorithm, which - for triangular comparison signal - results in a much smaller current ripple (see Examples.DCDC.HBridge.HBridge_DC_Drive).
On the other hand, the old layout could cause a short circuit on the source (which is avoided by the new layout).

@AHaumer AHaumer added enhancement New feature or enhancement L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters labels Nov 13, 2021
@AHaumer AHaumer added this to the MSL4.0.1 milestone Nov 13, 2021
@AHaumer AHaumer self-assigned this Nov 13, 2021
@AHaumer AHaumer added the bug Critical/severe issue label Nov 13, 2021
@beutlich beutlich modified the milestones: MSL4.0.1, MSL4.1.0 Nov 13, 2021
@beutlich beutlich linked an issue Nov 13, 2021 that may be closed by this pull request
@beutlich beutlich removed their request for review November 13, 2021 21:39
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement. I've already rebased the branch onto master.

Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@christiankral christiankral merged commit 5ce526c into modelica:master Jan 19, 2022
@dietmarw dietmarw removed the request for review from DrMartinKuhn January 19, 2022 13:40
beutlich added a commit that referenced this pull request Jan 23, 2022
@beutlich beutlich assigned christiankral and unassigned AHaumer Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue enhancement New feature or enhancement L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fire signals of H-Bridge
4 participants