Update ModelicaTest/Media.mo: Reduce dp_nominal in TestsWithFluid.Components.PartialTestModel by a factor of 1000 #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced dp_nominal in TestsWithFluid.Components.PartialTestModel by a factor of 1000, which makes it reasonable, and will change all reference results in TestsWithFluid.
casella
approved these changes
Dec 14, 2021
|
@hubertus65 Is this for #3852? If yes you should self-assign there and link the PR. |
beutlich
changed the title
beutlich
added
the
L: ModelicaTest
|
Looks ok. I guess the failed check prevents the merge. |
|
The CI seems to work fine for branches that are not on the same repository. I am not sure why, but Jenkins thinks it's not a proper pull request... |
|
Ah, no.It shouldn't block the merge. It's the branch job that fails to build. The pr-merge job works fine. So if you're OK with it @AtiyahElsheikh approve the changes. |
|
@sjoelund I am ok. But there is no approve button. |
|
There should be something saying review and if you expand it, you can approve. |
|
I've removed myself from review since it is not really my field and I can not judge if the reduction is "reasonable". |
AtiyahElsheikh
approved these changes
Feb 2, 2022
thorade
approved these changes
Feb 2, 2022
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduced dp_nominal in TestsWithFluid.Components.PartialTestModel by a factor of 1000, which makes it reasonable, and will change all reference results in TestsWithFluid.