-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ModelicaTest/Media.mo: Reduce dp_nominal in TestsWithFluid.Components.PartialTestModel by a factor of 1000 #3918
Conversation
reduced dp_nominal in TestsWithFluid.Components.PartialTestModel by a factor of 1000, which makes it reasonable, and will change all reference results in TestsWithFluid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A nominal pressure drop of 1 GPa is definitely outlandish. 10 bars is also a lot, but reasonable in some applications.
@hubertus65 Is this for #3852? If yes you should self-assign there and link the PR. |
Looks ok. I guess the failed check prevents the merge. |
The CI seems to work fine for branches that are not on the same repository. I am not sure why, but Jenkins thinks it's not a proper pull request... |
Ah, no.It shouldn't block the merge. It's the branch job that fails to build. The pr-merge job works fine. So if you're OK with it @AtiyahElsheikh approve the changes. |
@sjoelund I am ok. But there is no approve button. |
There should be something saying review and if you expand it, you can approve. |
I've removed myself from review since it is not really my field and I can not judge if the reduction is "reasonable". |
reduced dp_nominal in TestsWithFluid.Components.PartialTestModel by a factor of 1000, which makes it reasonable, and will change all reference results in TestsWithFluid.