-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eddy current sources #3976
Eddy current sources #3976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but the unrelated (dummy) change should be removed from DemonstrateLightning.mo
for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still contains changes to DemonstrateLightning.mo
unfortunately.
Could you please point me to the changes, or just revert them? I donÄt see more than two empty lines that I removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Please squash commits to a single one before merge! |
removed unrelated changes (empty lines) in DemonstrateLightning.mo More realistic modeling of influence of excitation implemented optional influence of variable excitation
…icaStandardLibrary into EddyCurrentSources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AHaumer Very nice implementation!
Minor comments:
- To my understanding,
excitation
shall be between 0 and 1. If true, this shall be documented as well. Shall also ´excitation` be limited to these values in the eddy current brakes? - Maybe the equations for
tau
andf
can be given in the documentation as well - for better understanding.
Note: Changes in examples will trigger discrepances in regression tests.
You are right, negative excitation doen't make sense. |
One could even provide an auxilliary model consisting of resistance and inductance of the excitation winding, providing the excitaton signal (i.e. the magnetic flux of the inductance). This way one could model control of the excitation current as wel as the thermal analysis of the excitaton winding in a realistic way. |
I enabled auto-merge with squash to merge the changes as a single commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my opinion negative currents shall be allowed, as the sign of the current does not affect the generated torque. Additionally, overloading the eddy current source shall be possible. So I am in favor of not limiting the range of the current input.
Just a small backwards compatible improvement of already existing components:
Modelica.Mechanics.{Rotational, Translational}.Sources.EddyCurrent{Torque, Force} would be much more versatile if they would enable (optional) influence of excitation.