FluxTubes: some improvements in shapes and material

[AHaumer]

Checked all shapes, FluxTubes and QuasiStatic.FluxTubes in parallel

[dietmarw]

The new images have no longer a transparent background. Was that on purpose? This will look strange when compared to the other images that are still transparent.

[dietmarw]

@AHaumer I also had to revert your "???" commit once again here. Please follow the instruction I gave you of basing your future PRs on the current master (rather than keeping to merge the current master into your "broken" local master with that "???" commit).

[AHaumer]

The new images have no longer a transparent background. Was that on purpose? This will look strange when compared to the other images that are still transparent.

Sorry this was by mistake, I'll correct that. I suppose you mean the images for HollowCylinder RadialFlux and Axial Flux?

[AHaumer]

@AHaumer I also had to revert your "???" commit once again here. Please follow the instruction I gave you of basing your future PRs on the current master (rather than keeping to merge the current master into your "broken" local master with that "???" commit).

Sorry I didn't get that. Where did you give these instructions (PM or in a PR)? I don't know how to fix my broken master (and I have no idea how it got broken). Thanks in advance @dietmarw !

[AHaumer]

The new images have no longer a transparent background. Was that on purpose? This will look strange when compared to the other images that are still transparent.

Sorry this was by mistake, I'll correct that. I suppose you mean the images for HollowCylinder RadialFlux and Axial Flux?

I'm a little bit confused ... to me all images have a white background, also the older ones?
BTW, I don't see the difference between white and transparent background (at least in Dymola, in the parameter menu).

[AHaumer]

The new images have no longer a transparent background. Was that on purpose? This will look strange when compared to the other images that are still transparent.

Sorry this was by mistake, I'll correct that. I suppose you mean the images for HollowCylinder RadialFlux and Axial Flux?

I'm a little bit confused ... to me all images have a white background, also the older ones?
BTW, I don't see the difference between white and transparent background (at least in Dymola, in the parameter menu).

[dietmarw]

I'm a little bit confused ... to me all images have a white background, also the older ones? BTW, I don't see the difference between white and transparent background (at least in Dymola, in the parameter menu).

@AHaumer Have a look at the changed files here and scroll right to the bottom where GitHub shows you the changes to the images. As you can see the original had a checkered background (symbolising the transparency) the new ones have a plain white background which is not transparent. Dymola would only show you this if you started it in dark mode (-dark or /dark)

before it looked like this:

[AHaumer]

@dietmarw sorry I didn't see that. Also two other images have white instead of transparent background - corrected all four.
BTW please point out once again for me how I can repair my "broken" master. Thanks in advance!

[dietmarw]

@AHaumer Simply checkout your local master and reset it to upstream master and then you can create your topic branches for future PRs based on that again.

git fetch --all
git checkout master
git reset --hard upstream/master  # if your remote for MSL is called upstream

(edited to also fetch the latest states of remote first)

[beutlich]

Looks good to me. @AHaumer maybe you could also add the source files of the images next to the pngs?

You still can add them to this repo and exclude them from packaging in the attributes files like done here:

ModelicaStandardLibrary/.gitattributes

Lines 40 to 42 in 569c525

	Modelica/Resources/Documentation/Clocked/Modelica_Synchronous.pptx export-ignore
	Modelica/Resources/Documentation/Fluid/Stream-Connectors-Overview-Rationale.ppt export-ignore
	Modelica/Resources/Documentation/Mechanics/Figure_PlanarLoopAnalytic.ppt export-ignore

See also #2603.

[christiankral]

Some of the materials are brand names of the manufacturer Vacuumschmelze. The manufacturer uses the UPPERCASE spelling but in Modelica we have all kinds of different spelling mixed: For the sake of simplicity I propose to keep the used record names in order to avoid changing the record name in the next major release by means of a conversion script. In this case we should at least use the manufacturer name in the label or at least unify the spelling of the labels.

In the following PNG images the angle alfa shall be changed to either alpha or the greek letter $\alpha$:

• Modelica/Resources/Images/Magnetic/FluxTubes/Shapes/Circumferential.png
• Modelica/Resources/Images/Magnetic/FluxTubes/Shapes/Toroid.png

[christiankral]

As this ticket includes a bug fix, too, it shall be back-ported to MSL 4.0.0.

[dietmarw]

If that bugfix part is really important it should be isolated and not also mixed with all the extensions that this PR now contains. So question is, is it really such a severe bug (which one actually? Ticket?) or can we live with that until the next minor release.

[AHaumer]

If that bugfix part is really important it should be isolated and not also mixed with all the extensions that this PR now contains. So question is, is it really such a severe bug (which one actually? Ticket?) or can we live with that until the next minor release.

I just double-checked in detail:
I've been mistaken by some too complicated formulation of formulas for cross section (area A) and magnetic conductance Gm.
The most annoying topic was that some shapes in QuasiStatic.FluxTubes already had been improved with central angle alpha whereas the corresponding shapes in (transient) FluxTubes had fixed central angle = 2*pi.
Therefore no need for backporting but in my humble opinion improvements.

I'll replace "bug" by "improvement" in the title and the label of this PR.

[AHaumer]

Looks good to me. @AHaumer maybe you could also add the source files of the images next to the pngs?

You still can add them to this repo and exclude them from packaging in the attributes files like done here:

ModelicaStandardLibrary/.gitattributes

Lines 40 to 42 in 569c525

	Modelica/Resources/Documentation/Clocked/Modelica_Synchronous.pptx export-ignore
	Modelica/Resources/Documentation/Fluid/Stream-Connectors-Overview-Rationale.ppt export-ignore
	Modelica/Resources/Documentation/Mechanics/Figure_PlanarLoopAnalytic.ppt export-ignore

See also #2603.

I've included the sources (Visio) for images. Thanks @beutlich for the hint about gitattributes.

[christiankral]

In the following PNG images the angle alfa shall be changed to either alpha or the greek letter :

• Modelica/Resources/Images/Magnetic/FluxTubes/Shapes/Circumferential.png
• Modelica/Resources/Images/Magnetic/FluxTubes/Shapes/Toroid.png

This is not yet resolved.

[christiankral]

OK now