-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotations #4147
Fix annotations #4147
Conversation
@HansOlsson You mean But looking in the calculation of Regarding a default value, IMO this function would be used by an experienced user who knows about necessary inputs for homogenous/heterogenous approaches. So maybe a default value could be acceptable here. |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to me.
…rface has =false for it.
…c design doesn't work.
df8d3d2
to
cfe437c
Compare
Avoid using unknown parameters in annotations.
Only one of the changes is somewhat controversial - but having enable evaluating to false on a function input without a default-value simply doesn't work, and I'm not comfortable with adding a default value.