-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update text annotations to not use deprecated features #4181
Conversation
.../QuasiStatic/FundamentalWave/Examples/BasicMachines/SynchronousMachines/SMR_CurrentSource.mo
Outdated
Show resolved
Hide resolved
…chines/SynchronousMachines/SMR_CurrentSource.mo
Previously, a Text.lineColor annotation was not detected, if there was a closing parenthesis (within a quoted Text.textString annotation), e.g. ``` Text(extent={{-100,80},{-80,60}}, textString="1)", lineColor={0,0,255}) ```
Thanks for fixing. I adapted the CI check by #4183 to also detect such corner cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to me
Please note, that I pushed new changes to finally fix #4180 as reported by @abuntrock. |
I was wondering why the conversion didn't catch this, until I noticed that it wasn't named "lineColor", but "color" which has never been correct. (And the next Dymola version will handle it.) |
Co-authored-by: tobolar <tobolar@users.noreply.github.com>
I'm a bit unsure who can review it to make it clear for merging, due to "New changes require approval from someone other than the last pusher"? (I guess @tobolar being a co-author on the last one is the issue, but I'm not sure.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to me (again).
@HansOlsson Seems you are right. I supposed it was due to @beutlich but "re-requesting" my own review resolved the lock. I guess you can merge this now. |
Previously, a Text.lineColor annotation was not detected, if there was a closing parenthesis (within a quoted Text.textString annotation), e.g. ``` Text(extent={{-100,80},{-80,60}}, textString="1)", lineColor={0,0,255}) ```
Fixes #4180
Note that it both replaces textColor and removes deprecated attributes.
(There might be few unneeded formatting changes, might clear up.)