Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newlines at end of Text primitive #4187

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Remove newlines at end of Text primitive #4187

merged 2 commits into from
Dec 13, 2023

Conversation

maltelenz
Copy link
Contributor

Newline behavior in Text primitives is undefined, and in these cases seem to serve no purpose regardless.

@maltelenz
Remove newlines at end of Text primitive.
38c803d 
Newline behavior in Text primitives is undefined, and in these cases seem to serve no purpose regardless.
@beutlich beutlich added this to the MSL4.1.0 milestone Sep 13, 2023
@beutlich beutlich added the L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave label Sep 13, 2023
@beutlich beutlich changed the title Remove newlines at end of Text primitive. Remove newlines at end of Text primitive Sep 13, 2023
@beutlich beutlich enabled auto-merge (squash) September 13, 2023 05:04
AHaumer
AHaumer approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed at MAP-Lib monthly 2023-12-12

HansOlsson
HansOlsson approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@beutlich beutlich merged commit e51c78d into modelica:master Dec 13, 2023
2 checks passed
@maltelenz maltelenz deleted the bugfix/newlines-in-text-primitive branch December 13, 2023 09:36
@beutlich beutlich removed the request for review from christiankral December 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AHaumer AHaumer AHaumer approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maltelenz @AHaumer @HansOlsson @beutlich