-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit errors in ExternalCombiTimeTable constructor #4188
Fix unit errors in ExternalCombiTimeTable constructor #4188
Conversation
The errors are in relation to how the constructor is called in Modelica.Blocks.Sources.CombiTimeTable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, in #1473 (comment) I stated that the code is correct w.r.t. quantities and units.
I'm sure you had good intentions, even though a small mistake may have slipped by. |
Changing the name of one input argument of the external object ctor is a backwards-compatibility breaking change. I guess a conversion script will be required in that case. |
Right, but right now I don't think it looks like the argument names should be changed, since it apparently isn't the intention that those arguments must be "scaled time". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The errors are in relation to how the constructor is called in Modelica.Blocks.Sources.CombiTimeTable:
ModelicaStandardLibrary/Modelica/Blocks/Sources.mo
Lines 1639 to 1643 in ce36c07