Fix unit errors in ExternalCombiTimeTable constructor

[henrikt-ma]

The errors are in relation to how the constructor is called in Modelica.Blocks.Sources.CombiTimeTable:

ModelicaStandardLibrary/Modelica/Blocks/Sources.mo

Lines 1639 to 1643 in ce36c07

	startTime/timeScale,
	columns,
	smoothness,
	extrapolation,
	shiftTime/timeScale,

[beutlich]

Hm, in #1473 (comment) I stated that the code is correct w.r.t. quantities and units.

[henrikt-ma]

Hm, in #1473 (comment) I stated that the code is correct w.r.t. quantities and units.

I'm sure you had good intentions, even though a small mistake may have slipped by.

[beutlich]

Changing the name of one input argument of the external object ctor is a backwards-compatibility breaking change. I guess a conversion script will be required in that case.

[henrikt-ma]

Changing the name of one input argument of the external object ctor is a backwards-compatibility breaking change. I guess a conversion script will be required in that case.

Right, but right now I don't think it looks like the argument names should be changed, since it apparently isn't the intention that those arguments must be "scaled time".

[HansOlsson]

Looks good.