Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all defined outputs of the test example to reference signals #4195

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tobolar
Copy link
Contributor

@tobolar tobolar commented Sep 18, 2023

No description provided.

@tobolar tobolar added the L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined label Sep 18, 2023
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense for better testing.

But the harmonic part is just weird: we internally generate re and im parts, then in harmonic convert to polar, and then outside the harmonic component we convert back to re and im, and then to polar again!

@tobolar
Copy link
Contributor Author

tobolar commented Sep 18, 2023

we internally generate re and im parts, then in harmonic convert to polar, and then outside the harmonic component we convert back to re and im, and then to polar again!

Probably to test also PolarToRectangular and RectangularToPolar in just one test?

@beutlich beutlich added L: Resources Issue addresses Modelica/Resources (excl. C-Sources) ref-result Issue addresses the reference results L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined and removed L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined L: Resources Issue addresses Modelica/Resources (excl. C-Sources) labels Sep 18, 2023
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@beutlich beutlich added this to the MSL4.1.0 milestone Sep 18, 2023
@tobolar tobolar self-assigned this Sep 19, 2023
@tobolar tobolar merged commit e2661cc into modelica:master Nov 7, 2023
2 checks passed
@tobolar tobolar deleted the addReferenceSignalsForMean branch November 7, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined ref-result Issue addresses the reference results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants